git-credential-manager icon indicating copy to clipboard operation
git-credential-manager copied to clipboard

Published 20 hours ago • verified publisher icon git-ecosystem

Remove misleading error message

Open Regenhardt opened this issue 1 year ago • 1 comments

GitLab is used for internal hosting, which may often use unencrpted http. This error message is misleading, as the process continues and works regardless, and also falsely mentions Github instead of GitLab.

Got a new PC at work. First clone of the GitLab repo I'm working on went like this:

  • run git clone on an http GitLab instance, in my case I ran git clone http://gitlab.company-local-domain.de/group/project LocalRepo-Name Note:
    • http, not https
    • GitLab
  • Get the following error message: fatal: Unencrypted HTTP is not supported for GitHub. Ensure the repository remote URL is using HTTPS.
  • Get prompted for and enter credentials
  • Get warning about redirecting to .git URL
  • Cloning commences and finishes successfully

Regenhardt avatar Aug 22 '24 16:08 Regenhardt

Thank you for your PR! We have addressed this issue of not being able to use http:// remotes with GitLab with this other PR https://github.com/git-ecosystem/git-credential-manager/pull/1721

mjcheetham avatar Oct 07 '24 13:10 mjcheetham

That just changes the error message at default settings, but doesn't change the behaviour, does it? The message is then still misleading, as it implies that you have to change a setting and try again, but then still proceeds with the authentication?

Regenhardt avatar Oct 07 '24 13:10 Regenhardt