Dale McDiarmid

Results 147 comments of Dale McDiarmid

Thanks, @leonidboykov, for raising this. We return an err if a batch is not successful. Are you looking for automatic retries if a batch is not successful? or would you...

ok we'll improve @leonidboykov i think we'll try to make it as close to accurate as possible - if the stream is flushed we'll set it. Any errors before it...

So alittle more complexity here than i initially thought. Whilst we can in theory be more accurate on the `sent` flag it's there for a very good reason - when...

@GTB3NW can you provide an example of usage that requires these nil checks? Nil checks area common go pattern but appreciate it might be useful to be able to mock...

I dont quite understand why you can't just implement the [Conn interface](https://pkg.go.dev/github.com/ClickHouse/clickhouse-go/v2/lib/driver#Conn) with your own dummy connection? it's not the responsibility of the driver to provide dummy test connections.

@GTB3NW np at all. Happy to accept such a PR if its cleanly seperated e.g. under `./test-lib`

(2) is a limitation of ClickHouse itself. It returns all the columns - we have no way of knowing which are valid. We just serialize whats returned. (1) this seems...

This needs a custom http client - the standard HTTP client waits until all headers are read, before returning the response. I think DialContext should give us the hook we...

xz compression is the remaining task here. I would rather not write a specific lib to achieve this - I don't think its higher enough value. The main option appears...