single-file-cli icon indicating copy to clipboard operation
single-file-cli copied to clipboard

Published 20 hours ago • verified publisher icon gildas-lormeau

Homebrew

Open notDavid opened this issue 1 year ago • 9 comments

Hi there,

would be useful to be able to install / update via Homebrew.

Also convenient for people to track this issue to know when it's closed / implemented... :-)

Thank you!

notDavid avatar Mar 26 '24 13:03 notDavid

This will probably have to be a cask as building from source requires Deno. I will see if I can get this working, but I am having an error I have never seen before

AngelaDMerkel avatar Mar 26 '24 16:03 AngelaDMerkel

@AngelaDMerkel Thank you very much. I've never released sofware on Homebrew (and co.). Your help would be really precious. Don't hesitate to ping me if you need any help from me.

gildas-lormeau avatar Mar 26 '24 18:03 gildas-lormeau

@gildas-lormeau I have no clue what I am doing either and their documentation is pretty poor from my point of view. You can see the pull request here if you want to check on its progress. It looks like it has passed most of the checks.

AngelaDMerkel avatar Mar 27 '24 17:03 AngelaDMerkel

@gildas-lormeau Instead of using your precompiled binaries brew has asked me to write a small ruby package definition, which I have done and it successfully builds the single-file binary, but it appears that this binary still depends on single-file-launcher.js which doesn't get moved to homebrew's bin. Am I making a mistake in the compile process, or is it normal that building with Deno results in the need for these secondary files?

AngelaDMerkel avatar Apr 05 '24 15:04 AngelaDMerkel

@AngelaDMerkel That's strange. Could you give me a link to the related code? By the way, thank you again for your work, I read the thread but was a bit overwhelmed by the terms, not being used to homebrew and its ecosystem.

gildas-lormeau avatar Apr 06 '24 23:04 gildas-lormeau

@gildas-lormeau I've resolved it now, and all the build and run test are passing in my PR https://github.com/Homebrew/homebrew-core/pull/168436

I am not sure they will merge given that I always fail their commit style test. I have no clue what I am doing incorrectly, but hopefully someone will just approve it and it'll be merged

AngelaDMerkel avatar Apr 09 '24 15:04 AngelaDMerkel

@AngelaDMerkel That's a great news :) Did you try to add an explanation for the commit as documented here https://docs.brew.sh/Formula-Cookbook#commit ? The complete commit message could be be for example:

single-file 2.0.29 (new formula)

adds formula for single-file CLI tool

gildas-lormeau avatar Apr 10 '24 21:04 gildas-lormeau