openapi-generator-dart icon indicating copy to clipboard operation
openapi-generator-dart copied to clipboard

Add updateAnnotatedFile property

Open aoisupersix opened this issue 1 year ago • 5 comments
trafficstars

Fixes #131

This PR adds updateAnnotatedFile property to @OpenApi() annotation.

When the timestamp is forcibly added or updated to the @OpenApi() annotated class, frequent differences occur in source control. Therefore, by adding the updateAnnotatedFile property, if false is set, the addition or update of the timestamp will not be performed.

@Openapi(
  ...
  updateAnnotatedFile: false,
)

Default is true to keep current behavior.

The operation was checked by uncommenting in openapi-generator/pubspec.yaml.

# dependency_overrides:
#  openapi_generator_annotations:
#    path: ../openapi-generator-annotations

aoisupersix avatar Mar 17 '24 11:03 aoisupersix

We tested it on 5 APIs, and it worked perfectly. Thanks

Rick-VA avatar Apr 05 '24 07:04 Rick-VA

Also interested in this. When this can be merged?

DmitrySboychakov avatar Aug 14 '24 12:08 DmitrySboychakov

Great change! Please merge :)

tjarvstrand avatar Aug 20 '24 14:08 tjarvstrand

This PR is blocked because it requires a review from a user with write permissions. Also the package update process will likely be necessary after merge. Therefore need to wait for owner (@gibahjoe) to respond.

139

aoisupersix avatar Aug 20 '24 23:08 aoisupersix

@aoisupersix Yes, sorry, my comment was meant for @gibahjoe :)

tjarvstrand avatar Aug 21 '24 06:08 tjarvstrand