survHE icon indicating copy to clipboard operation
survHE copied to clipboard

consistent data names for `km` and `make.surv`

Open n8thangreen opened this issue 2 years ago • 3 comments

km in fit.model output names time, mean, upper and lower 95% CI as

time, surv, lower, upper

make.surv output names these as

t, S, low, upp.

This makes applying a common function to both of these more difficult.

n8thangreen avatar Nov 09 '22 12:11 n8thangreen

Thanks. That's actually a good point. I suspect that I may have messed up slightly though and that the naming is propagated throughout the other utility functions (mainly plotting...). Have you checked this? It's probably a matter of grep to check when we're calling what? Or have you changed in your version and can push the changes to the main repo?

Thanks!

giabaio avatar Nov 10 '22 08:11 giabaio

I don't think these fields from make.surv are used very much internally. All I can find is one in psa.plot(). I can have a go at changing them - and try some tests?

n8thangreen avatar Nov 10 '22 09:11 n8thangreen

Ha --- even better then... That'd be cool if you are playing with it anyway?

Thanks!

giabaio avatar Nov 10 '22 09:11 giabaio