Deleted user

> > So I can remove the amdgpu stuff right? > > Yes, we can add them back in a followup patch if needed. Ok.

My bad, I accidentally closed the pr. But I just reopened it. But hey you all, I will start addressing your review today but not sure If I will be...

@lntue ok I addressed your review

> Thanks for the patch! Everything is clean now! Thank you!

Other mods could probably use the addons (eg. Turbowarp using SA's addons), but the extension itself reaching to the sites would be a pain to maintain as it would need...

I have tested this item :white_check_mark: successfully on 1ac14e897d4e7960dfd9c2020bd4659d29537d50This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283.

Thanks @corco for suggesting more test cases! @fangism, @corco What do you both think about such case (current implementation reports it as violation): ``` module m; wire a1; begin assign...

You're right. It's not an implicit net declaration and it shouldn't be reported as violation. I thought it would be nice to report such assignment because it could be errror-prone....

Okay. I've modified my implementation. First of all I've concentrated on Visitor pattern and extended `TreeContexVisitor`. I'm using `ScopeTreeVisitor` to build scope stack (with declared & referenced nets) and call...

I agree with @fangism. I'll keep the testsuite and re-implement it using current scope/symbol resolution code.