ggPMX icon indicating copy to clipboard operation
ggPMX copied to clipboard

Tynes science gh71 eta cov improvements

Open mattfidler opened this issue 3 years ago • 3 comments
trafficstars

mattfidler avatar Jun 08 '22 18:06 mattfidler

This also imports over 21 packages with the addition of plyr which we can't do.

It seems since the initial pull request, we took on the dplyr dependency anyway....

mattfidler avatar Jun 08 '22 18:06 mattfidler

Codecov Report

Merging #246 (f396b36) into master (8c53f63) will increase coverage by 0.71%. The diff coverage is 99.14%.

:exclamation: Current head f396b36 differs from pull request most recent head 4829b28. Consider uploading reports for the commit 4829b28 to get more accurate results

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   72.74%   73.46%   +0.71%     
==========================================
  Files          45       45              
  Lines        4095     4209     +114     
==========================================
+ Hits         2979     3092     +113     
- Misses       1116     1117       +1     
Impacted Files Coverage Δ
R/utils.R 82.70% <97.91%> (+3.34%) :arrow_up:
R/plot-eta-cov.R 98.07% <100.00%> (+1.37%) :arrow_up:
R/plot-individual.R 92.18% <0.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c53f63...4829b28. Read the comment docs.

codecov-commenter avatar Jun 08 '22 18:06 codecov-commenter

@tynsci

What are you trying to accomplish by plyr::as.quoted, and can we use one of the already loaded packages. I tried adding the function only from plyr but it seems I have to add all the s3 methods for quoted as well.

This isn't ready yet, but we could resurrect the dplyr method since we import it now anyway.

mattfidler avatar Jun 08 '22 20:06 mattfidler