packages icon indicating copy to clipboard operation
packages copied to clipboard

Published 20 hours ago • verified publisher icon getsolus

nano-syntax-highlighting: add at 2022.11.02

Open androidnisse opened this issue 1 year ago • 2 comments

Summary

  • Initial inclusion at version 2022.11.02
  • Resolves https://github.com/getsolus/packages/issues/2615

Test Plan

  • Checked some highlighting.

Checklist

  • [X] Package was built and tested against unstable

Packaging notes Nano depends on nanorc which conflicts with nano-syntax-highlighting. So this wont build without the conflicts tag. After this is pushed then nanorc can be deprecated at whole.

androidnisse avatar Jun 30 '24 06:06 androidnisse

This needs a rebase now

davidjharder avatar Jul 16 '24 19:07 davidjharder

@ReillyBrogan

This order of commits works locally. Can this be pushed now? See attached build log https://gist.github.com/androidnisse/24eff6e76316df96d7b319d55ea9a02f

androidnisse avatar Jul 17 '24 05:07 androidnisse

I can confirm that upgrading in this case works; nanorc is removed before nano-syntax-highlighting is installed.

EbonJaeger avatar Aug 29 '24 17:08 EbonJaeger

Unfortunately, this had to be reverted. I'll copy the explanation here:

Trying to build [this] PR does not work, I think because the Solus builder image is out of date, and thus tries to update nano, which doesn't work because of the dependency change. My local image is up-to-date, which is why it didn't show up when I built the PR stack locally.

EbonJaeger avatar Aug 30 '24 00:08 EbonJaeger

Unfortunately, this had to be reverted. I'll copy the explanation here:

Trying to build [this] PR does not work, I think because the Solus builder image is out of date, and thus tries to update nano, which doesn't work because of the dependency change. My local image is up-to-date, which is why it didn't show up when I built the PR stack locally.

Yea this went unexpected. Read up on matrix as well. What would be the procedure now get this in? As the issue seems to be on the build server and not the commits.

androidnisse avatar Aug 30 '24 10:08 androidnisse

Easiest probably to make sure build server solbuild image is absolutely up-to-date before pushing it (and with no system.base updates in-between).

Staudey avatar Aug 30 '24 21:08 Staudey

The solbuild image on the build server has been updated, so in theory, doing these updates again should work.

EbonJaeger avatar Aug 30 '24 23:08 EbonJaeger

The solbuild image on the build server has been updated, so in theory, doing these updates again should work.

So so I need to do anything here?

androidnisse avatar Aug 31 '24 04:08 androidnisse

I think it would be best to open a new PR; at least nano has to be re-based since I bumped it to make sure it still builds.

EbonJaeger avatar Aug 31 '24 14:08 EbonJaeger