sentry
sentry copied to clipboard
feat(member merge): merge account endpoint POST
POST request for the user merge account endpoint. The user passes in lists of ids that they want to merge and delete, and these are deleted/merged into the primary user account and deleted.
Codecov Report
Attention: Patch coverage is 97.18310% with 4 lines in your changes missing coverage. Please review.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...ntry/auth_v2/endpoints/auth_merge_user_accounts.py | 93.22% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #93395 +/- ##
===========================================
+ Coverage 76.32% 88.10% +11.77%
===========================================
Files 10589 10414 -175
Lines 609979 604018 -5961
Branches 23989 22835 -1154
===========================================
+ Hits 465593 532179 +66586
+ Misses 142454 71393 -71061
+ Partials 1932 446 -1486
🚨 Warning: This pull request contains Frontend and Backend changes!
It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.
Have questions? Please ask in the #discuss-dev-infra channel.
Bug: User Account Merge Fails Due to Unordered Token Retrieval
Bug: Unprotected Auth Endpoint Causes Account Merge Vulnerability
Was this report helpful? Give feedback by reacting with 👍 or 👎
First one is incorrect because there is unique constraint on user. @leedongwei let me know if I need the feature flag on this endpoint?