sentry icon indicating copy to clipboard operation
sentry copied to clipboard

ref: get proper base manager typing

Open asottile-sentry opened this issue 1 year ago • 2 comments

asottile-sentry avatar Jun 06 '24 14:06 asottile-sentry

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.08%. Comparing base (3dc95d7) to head (0d84170). Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72221      +/-   ##
==========================================
- Coverage   78.09%   78.08%   -0.01%     
==========================================
  Files        6758     6758              
  Lines      301731   301732       +1     
  Branches    51925    51925              
==========================================
- Hits       235624   235617       -7     
- Misses      59761    59765       +4     
- Partials     6346     6350       +4     
Files Coverage Δ
src/sentry/backup/imports.py 90.35% <100.00%> (ø)
src/sentry/db/models/manager/base.py 75.07% <100.00%> (+0.07%) :arrow_up:
src/sentry/models/files/abstractfile.py 90.36% <100.00%> (ø)
src/sentry/models/files/abstractfileblob.py 86.66% <100.00%> (ø)
...sentry/organizations/services/organization/impl.py 85.44% <100.00%> (ø)

... and 5 files with indirect coverage changes

codecov[bot] avatar Jun 06 '24 15:06 codecov[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Jun 28 '24 07:06 getsantry[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Jul 23 '24 07:07 getsantry[bot]

note that there are a number of "newly identified errors" in ignored files (~50-100) -- I'm deferring fixing those for now and will fix those as they get opted into type checking

asottile-sentry avatar Jul 29 '24 20:07 asottile-sentry