sentry icon indicating copy to clipboard operation
sentry copied to clipboard

feat(remote-config): Add API endpoints

Open cmanallen opened this issue 1 year ago • 3 comments

Adds API endpoints for managing SDK and user configuration.

Depends on: https://github.com/getsentry/sentry/pull/70805 Ref: https://github.com/getsentry/sentry/issues/70942

cmanallen avatar May 21 '24 16:05 cmanallen

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

github-actions[bot] avatar May 21 '24 16:05 github-actions[bot]

Bundle Report

Changes will decrease total bundle size by 58.24kB :arrow_down:

Bundle name Size Change
app-webpack-bundle-array-push 27.6MB 58.24kB :arrow_down:

codecov[bot] avatar May 21 '24 16:05 codecov[bot]

Can someone explain to me how this change increases the bundle size by 12 bytes?

cmanallen avatar May 21 '24 16:05 cmanallen

Codecov Report

Attention: Patch coverage is 93.89313% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 77.91%. Comparing base (516c5a5) to head (1a41fb1). Report is 138 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71259      +/-   ##
==========================================
- Coverage   77.91%   77.91%   -0.01%     
==========================================
  Files        6528     6531       +3     
  Lines      290925   291190     +265     
  Branches    50344    50373      +29     
==========================================
+ Hits       226663   226867     +204     
- Misses      58040    58082      +42     
- Partials     6222     6241      +19     
Files Coverage Δ
src/sentry/api/api_owners.py 100.00% <100.00%> (ø)
src/sentry/api/urls.py 100.00% <100.00%> (ø)
src/sentry/conf/server.py 87.62% <ø> (ø)
src/sentry/features/permanent.py 100.00% <ø> (ø)
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
src/sentry/remote_config/endpoints.py 96.42% <96.42%> (ø)
src/sentry/remote_config/storage.py 91.54% <91.54%> (ø)

... and 64 files with indirect coverage changes

codecov[bot] avatar May 22 '24 20:05 codecov[bot]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError: assert 200 == 404 pytest.runtest.protocol tests/sentry/remote_con... View Issue

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar May 30 '24 11:05 sentry[bot]

@cmanallen your new test is flaky -- can you disable it and fix it in a followup?

asottile-sentry avatar May 30 '24 13:05 asottile-sentry

@asottile-sentry Fixed in a follow-up https://github.com/getsentry/sentry/pull/71705 if you care to approve.

cmanallen avatar May 30 '24 13:05 cmanallen

I don't have anywhere near enough context to approve that and it has non-test changes as well

asottile-sentry avatar May 30 '24 13:05 asottile-sentry

@asottile-sentry Yeah fair enough. I'll get it approved by a team member and merged soon.

cmanallen avatar May 30 '24 14:05 cmanallen