sentry icon indicating copy to clipboard operation
sentry copied to clipboard

build: update redis and remove redis-py-cluster

Open anonrig opened this issue 1 year ago • 3 comments
trafficstars

Updates redis to v4.1.0 since it is the minimum Redis version that supports/includes RedisCluster

anonrig avatar Feb 06 '24 21:02 anonrig

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (922707e) 80.45% compared to head (c7d8950) 81.36%. Report is 15 commits behind head on master.

:exclamation: Current head c7d8950 differs from pull request most recent head f49a04b. Consider uploading reports for the commit f49a04b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #64711      +/-   ##
==========================================
+ Coverage   80.45%   81.36%   +0.91%     
==========================================
  Files        5243     5243              
  Lines      231444   231452       +8     
  Branches    45401    45402       +1     
==========================================
+ Hits       186208   188323    +2115     
+ Misses      39159    37268    -1891     
+ Partials     6077     5861     -216     
Files Coverage Δ
src/sentry/ingest/transaction_clusterer/rules.py 87.82% <100.00%> (-12.18%) :arrow_down:
src/sentry/processing/backpressure/memory.py 74.28% <100.00%> (ø)
src/sentry/ratelimits/redis.py 85.24% <100.00%> (+13.57%) :arrow_up:
src/sentry/statistical_detectors/redis.py 94.87% <100.00%> (ø)
src/sentry/tsdb/redis.py 91.46% <100.00%> (ø)
src/sentry/utils/kvstore/redis.py 89.47% <100.00%> (ø)
src/sentry/ratelimits/concurrent.py 89.79% <50.00%> (+0.21%) :arrow_up:
src/sentry/ratelimits/sliding_windows.py 87.23% <50.00%> (+0.27%) :arrow_up:
src/sentry/utils/redis.py 77.07% <81.81%> (-0.57%) :arrow_down:

... and 232 files with indirect coverage changes

codecov[bot] avatar Feb 08 '24 16:02 codecov[bot]

Blocked: https://github.com/getsentry/sentry/pull/64885

anonrig avatar Feb 09 '24 13:02 anonrig

image

CMDMichalKoval avatar Feb 09 '24 19:02 CMDMichalKoval

PR reverted: c699781d7e0b8ecd8234e14ed6f5a02b76d1932a

getsentry-bot avatar Feb 15 '24 16:02 getsentry-bot