sentry-native icon indicating copy to clipboard operation
sentry-native copied to clipboard

Adding minidump to event hides exception data.

Open eakoli opened this issue 5 years ago • 5 comments

We are generating events from cpp exceptions using the std::terminate_handler hook. Attaching the exception detail as documented here https://docs.sentry.io/platforms/native/#exceptions Everything works fine and shows up correctly on sentry (the name of type and value).

But if we also attach a mini dump to the event (via Breakpad) the sentry issue changes to show that its a DUMP_REQUESTED, instead of a CPP exception, and the type/value provided in the exception node is not shown anywhere in the report.

Is this a limitation of the server side that a mini dump "trumps" all other exception information? Is there a proper way to attach the minimum so that its used to provide only the thread states and not any 'crash' info?

eakoli avatar Jun 01 '20 18:06 eakoli

a mini dump "trumps" all other exception information?

I think it does. Essentially the minidump will create an event internally, and the rest of the envelope is only used for scope information. @jan-auer can say more probably.

Swatinem avatar Jun 02 '20 08:06 Swatinem

Right, this needs changing on the server. It totally makes sense to preserve the original exception information if provided manually. There's no way to fix this in the SDK at the moment.

jan-auer avatar Jun 02 '20 10:06 jan-auer

This issue is stale. Closing. Please reopen if necessary.

jernejstrasner avatar Dec 06 '23 18:12 jernejstrasner

@jernejstrasner

This is still an issue, although locally we have worked around it by altering sentry to be able to provide info about all current threads by thread walking and reporting it in the threads nodes.

But ideally it would be best if the minidump was able to be included in any request to provide thread state and not be considered the "source" of an error, unless explicitly named as the source.

eakoli avatar Dec 06 '23 20:12 eakoli

@eakoli thanks for letting us know, I'll reopen then!

jernejstrasner avatar Dec 15 '23 10:12 jernejstrasner