sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

feat(node): Add `tedious` integration

Open Zen-cronic opened this issue 1 year ago • 4 comments

Resolves #13316

Implement Tedious OTL instrumentation in packages/node.

  • [x] If you've added code that should be tested, please add tests.
  • [x] Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic avatar Aug 27 '24 23:08 Zen-cronic

The check Node (22) (TS 3.8) Integration Tests is a consistent fail - observed in previous commits as well.

This is b/c:

  • tedious 15.1.3 is the newest version that supports node >= 14.
  • That version of tedious depends on @azure/identity 2.1.0.
  • Which in turn depends on @azure/msal-node 1.18.4. This (deprecated) package doesn't support node 22, causing the failed check.

We could bump tedious to 16.x.x or later, but those versions lacks support for node 14 and/or 16.

Zen-cronic avatar Aug 30 '24 19:08 Zen-cronic

We could bump tedious to 16.x.x or later, but those versions lacks support for node 14 and/or 16.

I recommend we add support for a newer version that may not be supporting as many older node versions!

lforst avatar Sep 02 '24 09:09 lforst

I recommend we add support for a newer version that may not be supporting as many older node versions!

Noted! I'll look into it then.

Zen-cronic avatar Sep 03 '24 01:09 Zen-cronic

I recommend we add support for a newer version that may not be supporting as many older node versions!

Noted! I'll look into it then.

Bumped to 18.6.1, which supports node >=18.

Zen-cronic avatar Oct 03 '24 16:10 Zen-cronic

Hey @Zen-cronic, apologies for the delay in reviewing this! I'd like to help push this forward so I'm going to push some commits to this branch to resolve conflicts and get it up to date.

AbhiPrasad avatar Nov 06 '24 18:11 AbhiPrasad

awesome!

Zen-cronic avatar Nov 06 '24 19:11 Zen-cronic