sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

Enable `includeLocalVariables` by default

Open AbhiPrasad opened this issue 1 year ago • 3 comments

Description

https://sentry.slack.com/archives/CA2V2LBDL/p1721771426857869

We should do one final benchmark before we carry on with this

AbhiPrasad avatar Jul 24 '24 16:07 AbhiPrasad

For the time being, we can add includeLocalVariable: true to all the onboarding docs until this change is added and released.

AbhiPrasad avatar Jul 24 '24 16:07 AbhiPrasad

If I may suggest, take a look at (and hopefully address) #13414 #13415 #13416 and #13417 as there appears to be some buggy behaviour that should likely get solved first, before defaulting this to enabled? Or at least some documentation around eg. that debugging is not possible with this enabled.

Bruno-DaSilva avatar Aug 18 '24 00:08 Bruno-DaSilva

@Bruno-DaSilva Thanks for the reports. We'll consider those before doing anything in the direction of enabling (or suggesting) by default.

lforst avatar Aug 26 '24 07:08 lforst