sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

Use `@opentelemetry/instrumentation-undici`

Open mydea opened this issue 1 year ago • 4 comments

There is a somewhat new instrumentation now for node-fetch which we could use instead of the community one we are using today: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/instrumentation-undici

However, in order to maintain feature parity, we need to land this first: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/2265

mydea avatar Jun 07 '24 08:06 mydea

  • https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2356

timfish avatar Jul 29 '24 20:07 timfish

Once this is released I'll open a PR to migrate to the official instrumentation.

  • https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2375

timfish avatar Aug 14 '24 08:08 timfish

Will this replace the opentelemetry-instrumentation-fetch-node dependency? If so, it will be very helpful. The latter ships an older version of opentelemetry (due to a too-restrictive version range), and has generally been problematic in our app - we had to disable the respective integration in Sentry.init.

amakhrov avatar Aug 16 '24 23:08 amakhrov

@amakhrov yes it will replace opentelemetry-instrumentation-fetch-node.

lforst avatar Aug 26 '24 08:08 lforst