sentry-dotnet icon indicating copy to clipboard operation
sentry-dotnet copied to clipboard

Rename types likely to clash to include `ImplicitUsings` by default

Open bruno-garcia opened this issue 3 years ago • 3 comments
trafficstars

See: https://github.com/getsentry/sentry-dotnet/issues/1487

bruno-garcia avatar Feb 18 '22 00:02 bruno-garcia

Clear example, Sentry.Span conflicting with System.Span<T>.

Before simply renaming everything, we should re-think our type names within the context of implict/global usings. Does the whole .NET ecosystem need to re-think this? Are these conversations already happening, and can we align to what others might be doing?

mattjohnsonpint avatar Mar 17 '22 19:03 mattjohnsonpint

Discussed. I think we should do this for the next major (4.0), especially in light of global usings. Another good example is Transaction, which should be SentryTransaction.

Lets do this as part of reviewing the public API surface for 4.0.

mattjohnsonpint avatar Apr 21 '22 19:04 mattjohnsonpint

See also #1585

mattjohnsonpint avatar Apr 21 '22 21:04 mattjohnsonpint

We should give this one a try now on 4.0.0.

Adding ImplicitUsings to a project should allow you do do a basic SentrySdk.Init call and basic SentrySdk.CaptureException without having to do any using Sentry or Sentry.Anything

Wdyt @bitsandfoxes @jamescrosswell ?

bruno-garcia avatar Dec 02 '23 03:12 bruno-garcia

Wdyt @bitsandfoxes @jamescrosswell ?

From memory, we initially pushed this back to 5.0.0 from 4.0.0 to descope the 4.0 release a bit and make sure we'd be able to ship it around the same time as the .net8.0 release.

I think we've derisked that now so could potentially put this one back in there. It'd be an easy first issue to pick up.

jamescrosswell avatar Dec 03 '23 21:12 jamescrosswell

Since the 3.x SDK works fine on .NET 8, releasing 4.0.0 is not time sensitive. So if we want to extend the scope/time to take advantage of the major bump, we can

bruno-garcia avatar Dec 04 '23 17:12 bruno-garcia

What about Scope?

bitsandfoxes avatar Jan 08 '24 14:01 bitsandfoxes

What about Scope?

Since that'll be more prevalent going forward, to keep it in sync with most SDKs, I think it's fine we keep it as-is.

bruno-garcia avatar Jan 08 '24 16:01 bruno-garcia