sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

[Electron] Offline Integration

Open LSSangha opened this issue 3 years ago • 8 comments
trafficstars

Core or SDK?

Platform/SDK

Which part? Which one?

Electron

Description

A customer is requesting we provide an example of how to use the Offline integration for the Electron SDK.

Suggested Solution

Just adding a simple message or so, on how we they can use it for their SDK if needed or not.

LSSangha avatar Jul 28 '22 23:07 LSSangha

Routing to @getsentry/team-web-sdk-frontend for triage. ⏲️

getsentry-release avatar Jul 29 '22 12:07 getsentry-release

hey @LSSangha - when you have a minute, can you please make your github profile public so the issues you create as a team member don't have triage SLOs applied.

imatwawana avatar Jul 29 '22 12:07 imatwawana

The offline integration does not work with the Electron SDK. See a previous issue here: https://github.com/getsentry/sentry-docs/issues/4215.

We'll probably need to document how to configure the offline transport though, so backlogging this issue for that. cc @timfish whenever you get the time!

AbhiPrasad avatar Jul 29 '22 12:07 AbhiPrasad

Yep, need to add details for this.

The Electron SDK uses its own offline transport by default. From v4, there's a single configuration option that allows you to queue events rather than send which can be used to disable sending until confirmation of user consent.

timfish avatar Jul 29 '22 13:07 timfish

Please assign this issue to me!

timfish avatar Jul 29 '22 14:07 timfish

@AbhiPrasad @timfish a customer is asking if there are any other settings they need to turn on for the offline option to work.

LSSangha avatar Aug 30 '22 16:08 LSSangha

The offline transport has been the default transport since v3 of the Electron SDK and should work without any configuration.

I recently had a PR merged in this repo that removed references to the old JavaScript Offline integration that never worked with Electron.

It sounds like I need to do another PR that:

timfish avatar Aug 30 '22 16:08 timfish

Thank you. Are any addition configuration needed/recommended to enable offline?

We were setting this previous. Can you confirm this isn't needed for the new version?

"SENTRY_MAX_STORED_EVENTS": 10

From: Tim Fish @.> Sent: Tuesday, August 30, 2022 12:43 PM To: getsentry/sentry-docs @.> Cc: Jeffrey Brubaker @.>; Manual @.> Subject: Re: [getsentry/sentry-docs] [Electron] Offline Integration (Issue #5364)

*** This email originated from an EXTERNAL source ***

The offline transport has been the default since v3 of the Electron SDK and should work without any configuration.

I recently had a PR merged in this repo that removed references to the old JavaScript Offline integration that never worked with Electron.

It sounds like I need to do another PR that:

Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__github.com_getsentry_sentry-2Ddocs_issues_5364-23issuecomment-2D1231911649%26d%3DDwMCaQ%26c%3DAT5K1q9CQPGMXclhopmqpg%26r%3Dh-8yoPGAlcxP3DK_AZ075R66YjZqtwUnu3N_WgJ-LPM%26m%3DDGwi5UhrvXyjvcNKb6AlBB5W_bQb_biKJrnGGig-d_gj1BI3C0EwoI_UQaeYfHAN%26s%3D4xBbyEvxzEqKD0DOi-ukDkusl36nxSzeVhUMre_pHg4%26e%3D&data=05%7C01%7Cjeffrey.brubaker%40lcecorp.com%7C8c850984f2784710a0db08da8aa6ae0e%7Cdb2b00ac25d34eb1b4ffb431f318119a%7C0%7C0%7C637974745740404509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uhDD73d4WFjVc6R4mnuPmcoO2TMupsJR%2FAH4aW4Tz5o%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__github.com_notifications_unsubscribe-2Dauth_AUFDIYDRQQDG6K2C7R6IXW3V3Y2YTANCNFSM5467BIKQ%26d%3DDwMCaQ%26c%3DAT5K1q9CQPGMXclhopmqpg%26r%3Dh-8yoPGAlcxP3DK_AZ075R66YjZqtwUnu3N_WgJ-LPM%26m%3DDGwi5UhrvXyjvcNKb6AlBB5W_bQb_biKJrnGGig-d_gj1BI3C0EwoI_UQaeYfHAN%26s%3DyCq16E5XUZfeXwSdGgtlXLbBR5mhCJk1QPQaKBpe_uo%26e%3D&data=05%7C01%7Cjeffrey.brubaker%40lcecorp.com%7C8c850984f2784710a0db08da8aa6ae0e%7Cdb2b00ac25d34eb1b4ffb431f318119a%7C0%7C0%7C637974745740404509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=u5os4YoDuQ6d6BbdCIBoDlQF6wvmIMrrqytJYA7eBds%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.@.>>

CONFIDENTIALITY NOTICE: This message contains information which may be confidential or privileged. If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of the contents of this information is prohibited. If you have received this transmission in error, please notify me immediately by telephone.

jebrubaker avatar Aug 30 '22 18:08 jebrubaker