sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Add multi-view troubleshooting guide for sentry dart

Open martinhaintz opened this issue 1 year ago â€ĸ 5 comments

DESCRIBE YOUR PR

Multi-view for web was introduced in Flutter 3.24. As the current sentry dart package is not 100% compatible with this feature I added a guide, how to use sentry with multi-view in Flutter web.

Flutter 3.24 Flutter Docs for multi-view

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • [ ] Urgent deadline (GA date, etc.):
  • [ ] Other deadline:
  • [x] None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • [x] Checked Vercel preview for correctness, including links
  • [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • [ ] PR was reviewed and approved by a member of the Sentry docs team

martinhaintz avatar Sep 10 '24 11:09 martinhaintz

The latest updates on your projects. Learn more about Vercel for Git â†—ī¸Ž

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Nov 11, 2024 9:16am
develop-docs ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Nov 11, 2024 9:16am
sentry-docs ✅ Ready (Inspect) Visit Preview đŸ’Ŧ Add feedback Nov 11, 2024 9:16am

vercel[bot] avatar Sep 10 '24 11:09 vercel[bot]

Bundle Report

Changes will increase total bundle size by 14.38MB (80.48%) :arrow_up::warning:, exceeding the configured threshold of 5%.

Bundle name Size Change
sentry-docs-server* 7.44MB 7.44MB (100%) :arrow_up::warning:
sentry-docs-edge-server* 254.43kB 254.43kB (100%) :arrow_up::warning:
sentry-docs-client* 6.38MB 6.38MB (100%) :arrow_up::warning:
sentry-docs-server-cjs 8.89MB 301.93kB (3.51%) :arrow_up:
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) :arrow_down:

â„šī¸ *Bundle size includes cached data from a previous commit

codecov[bot] avatar Sep 10 '24 11:09 codecov[bot]

@martinhaintz pls see my latest comment and finish this pr

buenaflor avatar Sep 26 '24 11:09 buenaflor

@martinhaintz you need to merge in the latest changes from master, there has been a fix regarding the failing CI

buenaflor avatar Sep 30 '24 13:09 buenaflor

@buenaflor I updated the docs according to this new PR

martinhaintz avatar Oct 22 '24 11:10 martinhaintz

@lizokm I have reverted my changes because the new PR will not be merged soon. I have implemented all your changes from your last review and this PR can be merged now. However, the CI is failing with Vercel – changelog — Deployment has failed. Is there something I can do from my side, to resolve this failing CI?

martinhaintz avatar Oct 29 '24 07:10 martinhaintz

@martinhaintz you may need to merge in the latest changes from master again

kahest avatar Oct 29 '24 08:10 kahest