sentry-dart
sentry-dart copied to clipboard
Feat: Screenshots on reports
:scroll: Description
:bulb: Motivation and Context
Closes https://github.com/getsentry/sentry-dart/issues/556
:green_heart: How did you test it?
:pencil: Checklist
- [ ] I reviewed submitted code
- [ ] I added tests to verify changes
- [ ] I updated the docs if needed
- [ ] All tests passing
- [ ] No breaking changes
:crystal_ball: Next steps
Example: https://sentry.io/organizations/sentry-sdks/issues/2613488099/?project=5428562
Codecov Report
Base: 89.90% // Head: 89.90% // No change to project coverage :thumbsup:
Coverage data is based on head (
8169028) compared to base (870f5eb). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 89.90% 89.90%
=======================================
Files 106 106
Lines 3388 3388
=======================================
Hits 3046 3046
Misses 342 342
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
looks like the macOS hang again https://github.com/getsentry/sentry-dart/pull/576/checks?check_run_id=3472320682
looks like the macOS hang again https://github.com/getsentry/sentry-dart/pull/576/checks?check_run_id=3472320682
Ahhh, I really dislike that error :(
draft of the spec btw https://github.com/getsentry/develop/pull/422/files
| Fails | |
|---|---|
| :no_entry_sign: | Please consider adding a changelog entry for the next release. |
| Messages | |
|---|---|
| :book: | Do not forget to update Sentry-docs with your feature once the pull request gets approved. |
Instructions and example for changelog
Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.
Example:
## Unreleased
- Screenshots on reports ([#576](https://github.com/getsentry/sentry-dart/pull/576))
If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.
Generated by :no_entry_sign: dangerJS against 8169028c162f6949dd14b4ebb99d3a011f28b6af
Android Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 288.82 ms | 332.56 ms | 43.74 ms |
| Size | 5.94 MiB | 6.92 MiB | 1005.82 KiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb1a7c1075248085a3da029c96da78223902b131 | 332.98 ms | 381.55 ms | 48.57 ms |
| 322aa66508dd3f9d0f68edacb140bc1f9f53e3f5 | 284.98 ms | 341.76 ms | 56.78 ms |
| 633cf2e1c17c650e952b570d6a63d9d4d2256a14 | 289.36 ms | 340.38 ms | 51.02 ms |
| 9c5aec6059869d06fd3c0c37f68ef530fb707ceb | 287.33 ms | 320.94 ms | 33.61 ms |
| 870f5ebb0389ee8870a702da61188f0c7826b7e1 | 329.45 ms | 369.29 ms | 39.84 ms |
| 6d317ea0c2dcfba0d8300bc7693d2dc292486d01 | 303.46 ms | 356.06 ms | 52.60 ms |
| 72dfc836ec6ac6176efb374c4c1c3e3871f4117e | 298.62 ms | 340.14 ms | 41.52 ms |
| 4efee31c65f1fefbb85fc97598de6b3ae8fd93b4 | 308.92 ms | 368.68 ms | 59.76 ms |
| 49a149b6624c052f31433241245b0c8b7a2194e0 | 301.96 ms | 344.51 ms | 42.55 ms |
| 1c6eb5b33483c440c18525f0e946a9031d09863c | 350.69 ms | 393.86 ms | 43.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb1a7c1075248085a3da029c96da78223902b131 | 5.94 MiB | 6.92 MiB | 1005.76 KiB |
| 322aa66508dd3f9d0f68edacb140bc1f9f53e3f5 | 5.94 MiB | 6.92 MiB | 1005.75 KiB |
| 633cf2e1c17c650e952b570d6a63d9d4d2256a14 | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
| 9c5aec6059869d06fd3c0c37f68ef530fb707ceb | 5.94 MiB | 6.92 MiB | 1001.61 KiB |
| 870f5ebb0389ee8870a702da61188f0c7826b7e1 | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
| 6d317ea0c2dcfba0d8300bc7693d2dc292486d01 | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
| 72dfc836ec6ac6176efb374c4c1c3e3871f4117e | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
| 4efee31c65f1fefbb85fc97598de6b3ae8fd93b4 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
| 49a149b6624c052f31433241245b0c8b7a2194e0 | 5.94 MiB | 6.92 MiB | 1001.54 KiB |
| 1c6eb5b33483c440c18525f0e946a9031d09863c | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
iOS Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 1276.96 ms | 1306.33 ms | 29.37 ms |
| Size | 8.15 MiB | 9.13 MiB | 1000.14 KiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1c6eb5b33483c440c18525f0e946a9031d09863c | 1277.85 ms | 1285.71 ms | 7.86 ms |
| 322aa66508dd3f9d0f68edacb140bc1f9f53e3f5 | 1251.68 ms | 1275.52 ms | 23.84 ms |
| 9c5aec6059869d06fd3c0c37f68ef530fb707ceb | 1266.51 ms | 1274.65 ms | 8.14 ms |
| 21845e2c4fd3604443616251b5d44240ea390663 | 1279.37 ms | 1298.81 ms | 19.45 ms |
| 4efee31c65f1fefbb85fc97598de6b3ae8fd93b4 | 1270.33 ms | 1285.75 ms | 15.42 ms |
| 49a149b6624c052f31433241245b0c8b7a2194e0 | 1296.47 ms | 1320.20 ms | 23.73 ms |
| 56810ff730b5c918da021c12c84ee1cd88d62aa1 | 1267.59 ms | 1293.48 ms | 25.89 ms |
| 870f5ebb0389ee8870a702da61188f0c7826b7e1 | 1267.78 ms | 1286.86 ms | 19.08 ms |
| 633cf2e1c17c650e952b570d6a63d9d4d2256a14 | 1257.96 ms | 1275.73 ms | 17.77 ms |
| 3e5ee375bd2c798addf97ddd5dac28201e4e1b8d | 1248.25 ms | 1265.38 ms | 17.13 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1c6eb5b33483c440c18525f0e946a9031d09863c | 8.15 MiB | 9.12 MiB | 986.27 KiB |
| 322aa66508dd3f9d0f68edacb140bc1f9f53e3f5 | 8.15 MiB | 9.12 MiB | 992.53 KiB |
| 9c5aec6059869d06fd3c0c37f68ef530fb707ceb | 8.15 MiB | 9.12 MiB | 986.23 KiB |
| 21845e2c4fd3604443616251b5d44240ea390663 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
| 4efee31c65f1fefbb85fc97598de6b3ae8fd93b4 | 8.15 MiB | 9.12 MiB | 991.35 KiB |
| 49a149b6624c052f31433241245b0c8b7a2194e0 | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| 56810ff730b5c918da021c12c84ee1cd88d62aa1 | 8.15 MiB | 9.12 MiB | 987.35 KiB |
| 870f5ebb0389ee8870a702da61188f0c7826b7e1 | 8.15 MiB | 9.13 MiB | 1000.08 KiB |
| 633cf2e1c17c650e952b570d6a63d9d4d2256a14 | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| 3e5ee375bd2c798addf97ddd5dac28201e4e1b8d | 8.15 MiB | 9.12 MiB | 986.23 KiB |
Closing in favor of https://github.com/getsentry/sentry-dart/pull/1088