sentry-dart
sentry-dart copied to clipboard
fix: app starts hanging for 30s
:scroll: Description
Fixes timeouts still happening with autoAppStarts disabled and setAppStartEnd not being called
Also timeout has been reduced to 10s as 30s is a bit aggressive, maybe it makes sense to lower it even more?
:green_heart: How did you test it?
Unit tests
:pencil: Checklist
- [x] I reviewed submitted code
- [x] I added tests to verify changes
- [ ] No new PII added or SDK only sends newly added PII if
sendDefaultPiiis enabled - [ ] I updated the docs if needed
- [x] All tests passing
- [x] No breaking changes
:crystal_ball: Next steps
Let's discuss if setAppStartEnd is still needed.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.05%. Comparing base (
c614bf9) to head (6965d49).
Additional details and impacted files
@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
+ Coverage 88.42% 92.05% +3.62%
==========================================
Files 224 62 -162
Lines 7717 2038 -5679
==========================================
- Hits 6824 1876 -4948
+ Misses 893 162 -731
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Android Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 384.31 ms | 460.02 ms | 75.71 ms |
| Size | 6.35 MiB | 7.35 MiB | 1017.76 KiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6034b0a5af03e6891b1153ba6a88f095cbd7a948 | 406.35 ms | 475.93 ms | 69.59 ms |
| 6d317ea0c2dcfba0d8300bc7693d2dc292486d01 | 303.46 ms | 356.06 ms | 52.60 ms |
| 6957bfd77c4a7a9c90276a61f4814f494a146f3e | 325.88 ms | 380.30 ms | 54.43 ms |
| 78eeed5b9772f2cd873401dd922274703ba656c9 | 298.35 ms | 361.63 ms | 63.28 ms |
| 7f2b01dfe5e45d86582aa71aa0f4c56ff6d57b35 | 304.94 ms | 345.71 ms | 40.78 ms |
| 1c6eb5b33483c440c18525f0e946a9031d09863c | 350.69 ms | 393.86 ms | 43.17 ms |
| c9d3212f2912cb01a1648be804a482edeee6b791 | 301.34 ms | 361.58 ms | 60.24 ms |
| 08a7b4f192f3f168078d3e506ff732ff65e3e327 | 346.47 ms | 403.29 ms | 56.82 ms |
| 62de92771b3fa4340cc2e07bc1121f3a60a1fd79 | 313.81 ms | 358.15 ms | 44.34 ms |
| 11319141655ff681e0df68bce3cf03ffe9a95f30 | 317.90 ms | 361.58 ms | 43.69 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6034b0a5af03e6891b1153ba6a88f095cbd7a948 | 6.34 MiB | 7.29 MiB | 970.36 KiB |
| 6d317ea0c2dcfba0d8300bc7693d2dc292486d01 | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
| 6957bfd77c4a7a9c90276a61f4814f494a146f3e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 78eeed5b9772f2cd873401dd922274703ba656c9 | 6.16 MiB | 7.14 MiB | 1009.97 KiB |
| 7f2b01dfe5e45d86582aa71aa0f4c56ff6d57b35 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 1c6eb5b33483c440c18525f0e946a9031d09863c | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
| c9d3212f2912cb01a1648be804a482edeee6b791 | 6.16 MiB | 7.14 MiB | 1010.90 KiB |
| 08a7b4f192f3f168078d3e506ff732ff65e3e327 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 62de92771b3fa4340cc2e07bc1121f3a60a1fd79 | 6.15 MiB | 7.11 MiB | 981.78 KiB |
| 11319141655ff681e0df68bce3cf03ffe9a95f30 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
Previous results on branch: fix/app-starts-hanging
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 37bd8367961d7fd1e584ceb0b02cafd86aeb1bdb | 410.32 ms | 491.77 ms | 81.45 ms |
| 99f2252771480cc2009a2f563f6086a4aa365fcb | 379.71 ms | 451.43 ms | 71.71 ms |
| 03fe71715fc1a44b25ab59ce71df1c0157ac2d13 | 397.83 ms | 466.73 ms | 68.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 37bd8367961d7fd1e584ceb0b02cafd86aeb1bdb | 6.35 MiB | 7.35 MiB | 1017.77 KiB |
| 99f2252771480cc2009a2f563f6086a4aa365fcb | 6.35 MiB | 7.35 MiB | 1017.77 KiB |
| 03fe71715fc1a44b25ab59ce71df1c0157ac2d13 | 6.35 MiB | 7.35 MiB | 1017.76 KiB |
iOS Performance metrics :rocket:
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 1246.10 ms | 1264.96 ms | 18.86 ms |
| Size | 8.33 MiB | 9.62 MiB | 1.29 MiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5112c69cbabc27fdee43278e7fae250aa56d0120 | 1272.76 ms | 1293.37 ms | 20.61 ms |
| 89ea268a7f626fd1b23c6ffa55ec68da030ea450 | 1252.33 ms | 1253.58 ms | 1.26 ms |
| be173fa4303b8b6dbd940568953214b4f5e60992 | 1364.84 ms | 1424.49 ms | 59.65 ms |
| 3334ac176f15a6d39b435960620ea9a4919aae79 | 1259.22 ms | 1275.40 ms | 16.17 ms |
| 0a82a1ee1ab16b08941011233f534636569d7543 | 1233.56 ms | 1244.56 ms | 11.00 ms |
| abcdba32324a0963ec44af1537d4444dac1699d3 | 1257.31 ms | 1283.49 ms | 26.18 ms |
| 4b5a4f6a2eb127d509b6927bbe9ff4220a3b5289 | 1245.28 ms | 1272.27 ms | 26.99 ms |
| 3de8b9b92406e56cedb15086ae779e72d5cdfb08 | 1234.22 ms | 1251.94 ms | 17.72 ms |
| 6a40d32bc4bf55ea3c242a30e5a58839a34bc46d | 1253.50 ms | 1266.49 ms | 12.99 ms |
| d8519f962da363304b642a362b6d7d378877e71b | 1208.57 ms | 1229.80 ms | 21.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5112c69cbabc27fdee43278e7fae250aa56d0120 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 89ea268a7f626fd1b23c6ffa55ec68da030ea450 | 8.09 MiB | 9.16 MiB | 1.06 MiB |
| be173fa4303b8b6dbd940568953214b4f5e60992 | 8.33 MiB | 9.54 MiB | 1.22 MiB |
| 3334ac176f15a6d39b435960620ea9a4919aae79 | 8.10 MiB | 9.17 MiB | 1.08 MiB |
| 0a82a1ee1ab16b08941011233f534636569d7543 | 8.29 MiB | 9.37 MiB | 1.08 MiB |
| abcdba32324a0963ec44af1537d4444dac1699d3 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
| 4b5a4f6a2eb127d509b6927bbe9ff4220a3b5289 | 8.32 MiB | 9.39 MiB | 1.07 MiB |
| 3de8b9b92406e56cedb15086ae779e72d5cdfb08 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 6a40d32bc4bf55ea3c242a30e5a58839a34bc46d | 8.29 MiB | 9.37 MiB | 1.08 MiB |
| d8519f962da363304b642a362b6d7d378877e71b | 8.32 MiB | 9.38 MiB | 1.05 MiB |
Previous results on branch: fix/app-starts-hanging
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 99f2252771480cc2009a2f563f6086a4aa365fcb | 1251.37 ms | 1269.87 ms | 18.50 ms |
| 03fe71715fc1a44b25ab59ce71df1c0157ac2d13 | 1248.22 ms | 1270.33 ms | 22.11 ms |
| 37bd8367961d7fd1e584ceb0b02cafd86aeb1bdb | 1240.71 ms | 1258.24 ms | 17.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 99f2252771480cc2009a2f563f6086a4aa365fcb | 8.33 MiB | 9.62 MiB | 1.29 MiB |
| 03fe71715fc1a44b25ab59ce71df1c0157ac2d13 | 8.33 MiB | 9.62 MiB | 1.29 MiB |
| 37bd8367961d7fd1e584ceb0b02cafd86aeb1bdb | 8.33 MiB | 9.62 MiB | 1.29 MiB |
I will test this later today.
Verified with Spotlight that this works for my use case 🚀