sentry-dart icon indicating copy to clipboard operation
sentry-dart copied to clipboard

Exception aggregate mechanism

Open ueman opened this issue 1 year ago • 6 comments

:scroll: Description

Adds the new field according to https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md#new-mechanism-fields

I didn't yet implement exception aggregates for anything. That can be done in follow-up PRs. The current CI failures are due to targeting the v8 branch, I believe. At least, I can't see any failures related to the new code.

:bulb: Motivation and Context

https://github.com/getsentry/rfcs/blob/main/text/0079-exception-groups.md

A tiny step towards #1859

:green_heart: How did you test it?

Updated tests

:pencil: Checklist

  • [x] I reviewed submitted code
  • [x] I added tests to verify changes
  • [x] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • [x] I updated the docs if needed
  • [x] All tests passing
  • [x] No breaking changes

:crystal_ball: Next steps

Use it for PlatformException in the Flutter code.

ueman avatar Feb 05 '24 18:02 ueman

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.55%. Comparing base (fab52eb) to head (1cd7fbb). Report is 245 commits behind head on release/8.0.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/8.0.0    #1866    +/-   ##
===============================================
  Coverage          88.55%   88.55%            
===============================================
  Files                205      218    +13     
  Lines               6884     7522   +638     
===============================================
+ Hits                6096     6661   +565     
- Misses               788      861    +73     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 05 '24 18:02 codecov[bot]

some tests are still failing it looks like

buenaflor avatar Feb 06 '24 19:02 buenaflor

@buenaflor I've fixed the issues. Is the target branch still the correct one, or should I target another branch?

ueman avatar Feb 08 '24 10:02 ueman

release/8.0.0 is fine, thx, I'll merge once everything is green (except sentry-dio, that's expected to fail currently fyi)

buenaflor avatar Feb 08 '24 10:02 buenaflor

@buenaflor Is there something I still need to do here? As far as I can tell, the remaining failing jobs aren't related to this PR.

ueman avatar Mar 05 '24 18:03 ueman

I'll merge main into v8 soon and the ci should be green then

buenaflor avatar Mar 06 '24 09:03 buenaflor