sentry-dart icon indicating copy to clipboard operation
sentry-dart copied to clipboard

Split up Flutter's `default_integrations.dart` into one file for each integration

Open ueman opened this issue 3 years ago • 5 comments
trafficstars

:scroll: Description

Split up default_integrations.dart into one file for each integration. This should make it easier to maintain a good overview about the integrations.

#skip-changelog

:bulb: Motivation and Context

There were a lot of integrations in a single file. That was hard to keep track of.

:green_heart: How did you test it?

Current test cover this.

:pencil: Checklist

  • [x] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] I updated the docs if needed
  • [x] All tests passing
  • [x] No breaking changes

:crystal_ball: Next steps

ueman avatar Oct 01 '22 14:10 ueman

Codecov Report

Base: 89.98% // Head: 89.90% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (e43c3b9) compared to base (e187bee). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
- Coverage   89.98%   89.90%   -0.09%     
==========================================
  Files         115      106       -9     
  Lines        3585     3388     -197     
==========================================
- Hits         3226     3046     -180     
+ Misses        359      342      -17     
Impacted Files Coverage Δ
dio/lib/src/sentry_dio_extension.dart
logging/lib/src/extension.dart
dio/lib/src/dio_event_processor.dart
dio/lib/src/breadcrumb_client_adapter.dart
dio/lib/src/tracing_client_adapter.dart
dio/lib/src/sentry_transformer.dart
dio/lib/src/sentry_dio_client_adapter.dart
dio/lib/src/failed_request_interceptor.dart
logging/lib/src/logging_integration.dart

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 01 '22 14:10 codecov-commenter

I will wait for https://github.com/getsentry/sentry-dart/pull/1039 before reviewing since it touches the same file and likely having conflicts.

marandaneto avatar Oct 03 '22 13:10 marandaneto

@ueman

Formatted 69 files (1 changed) in 1.09 seconds.

This is unblocked now, fixing the linter and we are good to go, thanks for doing this.

marandaneto avatar Oct 13 '22 09:10 marandaneto

@ueman

Formatted 69 files (1 changed) in 1.09 seconds.

This is unblocked now, fixing the linter and we are good to go, thanks for doing this.

Yeah, I also want to double check whether I messed up one of the merges, especially after the PlatformDispatcher PR

ueman avatar Oct 13 '22 10:10 ueman

This is now ready. Pana fails because it runs against the current published version :/

ueman avatar Oct 13 '22 15:10 ueman

Thanks @ueman

marandaneto avatar Oct 14 '22 06:10 marandaneto