sentry-dart
sentry-dart copied to clipboard
Split up Flutter's `default_integrations.dart` into one file for each integration
:scroll: Description
Split up default_integrations.dart into one file for each integration.
This should make it easier to maintain a good overview about the integrations.
#skip-changelog
:bulb: Motivation and Context
There were a lot of integrations in a single file. That was hard to keep track of.
:green_heart: How did you test it?
Current test cover this.
:pencil: Checklist
- [x] I reviewed submitted code
- [ ] I added tests to verify changes
- [ ] I updated the docs if needed
- [x] All tests passing
- [x] No breaking changes
:crystal_ball: Next steps
Codecov Report
Base: 89.98% // Head: 89.90% // Decreases project coverage by -0.08% :warning:
Coverage data is based on head (
e43c3b9) compared to base (e187bee). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
- Coverage 89.98% 89.90% -0.09%
==========================================
Files 115 106 -9
Lines 3585 3388 -197
==========================================
- Hits 3226 3046 -180
+ Misses 359 342 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I will wait for https://github.com/getsentry/sentry-dart/pull/1039 before reviewing since it touches the same file and likely having conflicts.
@ueman
Formatted 69 files (1 changed) in 1.09 seconds.
This is unblocked now, fixing the linter and we are good to go, thanks for doing this.
@ueman
Formatted 69 files (1 changed) in 1.09 seconds.
This is unblocked now, fixing the linter and we are good to go, thanks for doing this.
Yeah, I also want to double check whether I messed up one of the merges, especially after the PlatformDispatcher PR
This is now ready. Pana fails because it runs against the current published version :/
Thanks @ueman