sentry-dart-plugin icon indicating copy to clipboard operation
sentry-dart-plugin copied to clipboard

set `upload_sourcemaps` to true by default

Open buenaflor opened this issue 8 months ago • 5 comments

Not sure if there is a historic reason for it to be opt-in but I'd argue it's easier for the user to set up and the docs will be less.

looked at the first commit and it has always been false by default, I don't think there is much to argue against it being opt-out

buenaflor avatar Mar 12 '25 09:03 buenaflor

any concerns for this one? @denrase @kahest

imo it makes a lot of sense and couldn't find anything speaking against this change so far.

although we might need another major for this?

buenaflor avatar Mar 18 '25 10:03 buenaflor

@buenaflor I don't have context and can't think of reason why this is opt-in, maybe double-check with the team e.g. @krystofwoldrich @romtsn

kahest avatar Mar 18 '25 15:03 kahest

Me neither unfortunately, it has been opt-in since the very first commit of the plugin

buenaflor avatar Mar 18 '25 16:03 buenaflor

Might be worth releasing another dart plugin major with source maps upload by default + debug id injection by default

buenaflor avatar Apr 01 '25 13:04 buenaflor

We discussed this and won't be doing it for now. But I'll keep this issue open

buenaflor avatar May 06 '25 12:05 buenaflor