self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

ci: run tests on arm64

Open aldy505 opened this issue 5 months ago • 1 comments

Let's see if this works

Closes https://github.com/getsentry/self-hosted/issues/1586

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

aldy505 avatar Jun 14 '25 00:06 aldy505

Ah, symbolicator's still missing the nightly images published to DockerHub. Sigh..

aldy505 avatar Jun 19 '25 00:06 aldy505

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.45%. Comparing base (acbdee4) to head (a51e475). Report is 1 commits behind head on master.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3750   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          182      182           
  Misses          1        1           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 02 '25 02:07 codecov[bot]

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#standard-github-hosted-runners-for-public-repositories

Linux [Public preview] 4 16 GB 14 GB arm64 ubuntu-24.04-arm, ubuntu-22.04-arm

Arm is still in public preview of GHA, so maybe we should take cautions about adding it, as failing arm actions will prevent us from merging x86_64 fixes as well.

That was the thoughts of Sentry employees the first time I implemented this on all repositories (sentry, snuba, etc). We can remove it if it became troublesome, and it's not a required precondition in order to merge.

Also is there a problem with ubuntu 22? Changing multiple things in one PR always alerts me :-)

I don't remember that there are Ubuntu 22 ARM runners. So I went ahead for 24.04.

aldy505 avatar Jul 02 '25 08:07 aldy505