self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Build always shows as unknown in self-hosted

Open andrea-berling opened this issue 1 year ago • 2 comments

Environment

self-hosted (https://develop.sentry.dev/self-hosted/)

Steps to Reproduce

  1. Go to https://hub.docker.com/layers/getsentry/sentry/24.5.1/images/sha256-4c6e8885468559da05839b9f4034dcd80eaed6c67a7787f02b0e0fde08a422b4?context=explore
  2. Check out the value of SENTRY_BUILD at line 46

Expected Result

SENTRY_BUILD should point to the commit sha that was checked out when the Docker image was built

Actual Result

SENTRY_BUILD is set to unknown, indicating that the proper build argument (SOURCE_COMMIT) was not provided when the image was built. Compare with Dockerfile, ARG SOURCE_COMMIT. As a result, this is what is shown in the footer: image

Product Area

Footer

Link

No response

DSN

No response

Version

24.5.1

andrea-berling avatar Jun 25 '24 11:06 andrea-berling

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] avatar Jun 25 '24 11:06 getsantry[bot]

It's a known issue, but it doesn't impact anything though. The commit sha should be there. https://github.com/getsentry/sentry/blob/5f49d2a6ef0e41c57c0229d7125d8ab42571db29/static/app/components/footer.tsx#L39-L48

aldy505 avatar Jun 26 '24 00:06 aldy505

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Jul 17 '24 07:07 getsantry[bot]

https://github.com/getsentry/sentry/pull/76139

joshuarli avatar Aug 13 '24 23:08 joshuarli