self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

All links under point performance are broken

Open michaelmairegger opened this issue 1 year ago • 12 comments

Self-Hosted Version

24.6.0

CPU Architecture

x86_64

Docker Version

24.0.7

Docker Compose Version

2.27.1

Steps to Reproduce

Click on Queries and the new page shows:

The organization you were looking for was not found.

Expected Result

For e.g. queries the folowing URL should open: https://.../organizations/sentry/insights/database/

Actual Result

For e.g. queries the following URL opens:

https://.../insights/database/

Event ID

No response

michaelmairegger avatar Jun 19 '24 10:06 michaelmairegger

Hello, I have the same issue after upgrade to 24.6.0

cavanierc avatar Jun 19 '24 15:06 cavanierc

I am currently experiencing the same after upgrading.

SmoshySmosh avatar Jun 19 '24 22:06 SmoshySmosh

@KevinL10 @gggritso Hey, do you guys know anything related to this? I saw this PR that probably made the change, but since it's included in 24.5.1, I'm not too sure.

aldy505 avatar Jun 20 '24 06:06 aldy505

Enabling of feature "organizations:performance-insights" fixed this for me, but I still have useless "Caches", "Queues" and "LLM Monitoring" in navigation

pavel-boev avatar Jun 20 '24 06:06 pavel-boev

Enabling of feature "organizations:performance-insights" fixed this for me, but I still have useless "Caches", "Queues" and "LLM Monitoring" in navigation

@pavel-boev Would you like to add these features and then re-run install.sh script?

    # Rename current Performance modules to "Insights"
    "organizations:performance-insights",
    # Show links and upsells to Insights modules
    "organizations:insights-entry-points",
    # Enable access to initial Insights modules (Queries, Requests, Vitals, App Starts, Page Loads, Resources)
    "organizations:insights-initial-modules",
    # Enable access to newer Insights modules (Caches, Queues, LLMs, Mobile UI)
    "organizations:insights-addon-modules",

(from https://github.com/getsentry/sentry/blob/b0a45b072fb0cfceec3be5cad8e7a06ac58e60b1/src/sentry/features/temporary.py#L224-L225 and https://github.com/getsentry/sentry/blob/b0a45b072fb0cfceec3be5cad8e7a06ac58e60b1/src/sentry/features/temporary.py#L399-L404)

aldy505 avatar Jun 20 '24 08:06 aldy505

I prefer to keep "organizations:insights-addon-modules" disabled, because we don't use sentry for backend. But I still see these modules in the navigation with the disabled feature.

pavel-boev avatar Jun 20 '24 08:06 pavel-boev

Adding the 3 feature flags mentioned above to the sentry/sentry.conf.py and doing a ./install.sh does not fix this issue.

Its just weird, that the main menu item for Performance is working ( aka the link /organizations/myorg/performance/) but any link underneath (like /organizations/myorg/performance/database/) redirects to /insights/database/

In fact if I manually enter the URL /organizations/myorg/insights/database/ it works just fine. So something is stripping the /organizations/myorg/ part of the URL

LordSimal avatar Jun 20 '24 08:06 LordSimal

@LordSimal work for me

    "organizations:performance-insights",
    # Show links and upsells to Insights modules
    "organizations:insights-entry-points",
    # Enable access to initial Insights modules (Queries, Requests, Vitals, App Starts, Page Loads, Resources)
    "organizations:insights-initial-modules",
    # Enable access to newer Insights modules (Caches, Queues, LLMs, Mobile UI)
    "organizations:insights-addon-modules",
image

zKoz210 avatar Jun 20 '24 08:06 zKoz210

Indeed, I was missing organizations:performance-insights as well, so the following 2 features should be added to the sentry.config.py (as well as the sentry.config.example.py in this repo 😉)

"organizations:insights-addon-modules",
"organizations:performance-insights",

with that all the menu items work again

LordSimal avatar Jun 20 '24 08:06 LordSimal

👋🏻 hi everyone, sorry about the linking confusion!

  • "organizations:performance-insights" was removed in https://github.com/getsentry/sentry/pull/72962 a few days ago, so the next release of self-hosted doesn't need it
  • "organizations:insights-entry-points", "organizations:insights-initial-modules" and "organizations:insights-addon-modules" should be enabled

@aldy505 do you mind making that change and/or pointing me to where I should make it?

gggritso avatar Jun 20 '24 14:06 gggritso

This was the first issue I found regarding the error message: https://github.com/getsentry/sentry/issues/53431 Linking it here to make this issue appear over there...

stumbaumr avatar Jun 28 '24 11:06 stumbaumr

This was the first issue I found regarding the error message: https://github.com/getsentry/sentry/issues/53431

Linking it here to make this issue appear over there...

@stumbaumr This issue is not related to session replay. Are you referring to other issue? Or can you specify more of what you're experiencing?

aldy505 avatar Jun 28 '24 11:06 aldy505