self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

Add --no-recreate to dc up in wrap-up.sh only for docker-compose 2.2.4 and more

Open aminvakil opened this issue 3 years ago • 2 comments

Fixes #1294

Original PR: https://github.com/getsentry/self-hosted/pull/1393

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

aminvakil avatar Jul 27 '22 14:07 aminvakil

This should be merged after https://github.com/getsentry/self-hosted/pull/1591, so the change would be tested.

aminvakil avatar Jul 27 '22 14:07 aminvakil

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Sep 20 '22 00:09 github-actions[bot]

Do we still need this or do you think cons of this change which may appear, are more than the pros it has?

aminvakil avatar Sep 28 '22 14:09 aminvakil

/gcbrun

chadwhitacre avatar Mar 17 '23 18:03 chadwhitacre

Gonna go ahead and close this since we have not seen #1294 for a long time. Maybe #1591 fixed it? Let's revisit if we start seeing it again.

chadwhitacre avatar Mar 17 '23 18:03 chadwhitacre