Add macos-11 OS to CI

[aminvakil]

Fixes https://github.com/getsentry/self-hosted/issues/1586.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[aminvakil]

I'm completely confused, why is this saying linux/amd64, I was expecting darwin/arm64 :) https://github.com/getsentry/self-hosted/runs/7371688591?check_suite_focus=true#step:3:623

Also I should've asked this before, but we're only currently supporting linux systems on arm64? https://github.com/getsentry/self-hosted/blob/291004dc146a6061238cc15ae52bb8b535b6843e/install/detect-platform.sh#L22

[chadwhitacre]

Ooooh, nice! See also https://github.com/getsentry/self-hosted/issues/627 @aminvakil. :)

[aminvakil]

I'm completely confused, why is this saying linux/amd64, I was expecting darwin/arm64 :) https://github.com/getsentry/self-hosted/runs/7371688591?check_suite_focus=true#step:3:623

Also I should've asked this before, but we're only currently supporting linux systems on arm64?

https://github.com/getsentry/self-hosted/blob/291004dc146a6061238cc15ae52bb8b535b6843e/install/detect-platform.sh#L22

@ethanhs Can you tell me if my sentence "we're only currently supporting linux systems on arm64" is right or I'm misunderstanding something?

And if that so why is this macos test passing?

[emmatyping]

Can you tell me if my sentence "we're only currently supporting linux systems on arm64" is right or I'm misunderstanding something?

We will eventually, but the docker containers seem to not all work there. What works right now is aarch64 macOS, because docker will run containers that don't have ARM images (that are x86) under Rosetta. So actually we only support macOS systems on aarch64...

And if that so why is this macos test passing? Ah, because macOS uses a linux VM for docker!

[aminvakil]

Can you tell me if my sentence "we're only currently supporting linux systems on arm64" is right or I'm misunderstanding something?

We will eventually, but the docker containers seem to not all work there. What works right now is aarch64 macOS, because docker will run containers that don't have ARM images (that are x86) under Rosetta. So actually we only support macOS systems on aarch64...

And if that so why is this macos test passing? Ah, because macOS uses a linux VM for docker!

Aha, so do you think adding macos-11 to CI helps us?

[emmatyping]

Aha, so do you think adding macos-11 to CI helps us?

Yes. If nothing else, it exercises using a Docker Desktop version that runs in a VM, which might be good to test. Generally testing macOS will also help prevent regressions in local dev environments.

The macOS runners are x86, right?

[aminvakil]

Aha, so do you think adding macos-11 to CI helps us?

Yes. If nothing else, it exercises using a Docker Desktop version that runs in a VM, which might be good to test. Generally testing macOS will also help prevent regressions in local dev environments.

The macOS runners are x86, right?

Yes, https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources :

Hardware specification for macOS virtual machines:

3-core CPU (x86_64) 14 GB of RAM 14 GB of SSD space

[aminvakil]

I'm not sure about using docker-practice/actions-setup-docker@v1 though, I'd rather if we could do the work this action is doing ourselves, Although we should think more about pros/cons of manually doing it.

[github-actions[bot]]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[aminvakil]

Also I'm not quite OK with adding a third-party action to our CI, but couldn't setup docker on macos manually.

I think it's better to leave this to someone who has more experience with macOS rather than me :)

I'll close it and leave it for another one to pick it up some time later.