self-hosted icon indicating copy to clipboard operation
self-hosted copied to clipboard

Add macOS to CI

Open aminvakil opened this issue 3 years ago • 3 comments

Problem Statement

As arm64 support has been added to self-hosted since 22.7.0 it's good to add macOS to our CI to test on an arm64 cpu too.

Solution Brainstorm

Add macOS to CI matrix.

aminvakil avatar Jul 16 '22 16:07 aminvakil

We could close https://github.com/getsentry/self-hosted/issues/627 with this if we are willing to let go of the CentOS dream.

chadwhitacre avatar Jul 18 '22 21:07 chadwhitacre

I think so. CentOS is gone anyway, and running another image in a docker and try ./install.sh on it would be a mess and not worthy.

Although I'm sure I've seen places where different OSes have been used using qemu in GHA, but can't remember where :)

Although that would be too much trouble, I'll be happy to review a PR for it.

aminvakil avatar Jul 19 '22 08:07 aminvakil

Okay, how about we close #627 and go with the ticket and PR that you created.

chadwhitacre avatar Jul 19 '22 15:07 chadwhitacre