redash icon indicating copy to clipboard operation
redash copied to clipboard

Update maildev path in developer docker compose

Open rjmunro opened this issue 3 years ago • 6 comments

What type of PR is this? (check all applicable)

  • [x] Other

Description

The docker compose file was using an outdated path for the maildev test mail server. It's moved to maildev/maildev.

rjmunro avatar Mar 01 '22 13:03 rjmunro

Nice catch. Captured the following from docker hub today.

CleanShot 2022-03-03 at 13 11 37@2x

susodapop avatar Mar 03 '22 19:03 susodapop

Hello project maintainers @rjmunro @susodapop

I came across this pr by searching, recently maildev updated a new version, I recommend you to use the new version

docker image, maildev/maildev is not ready yet, you can use soulteary/maildev first, Hope it helps you

soulteary avatar Mar 23 '22 08:03 soulteary

Hey @rjmunro can you push an empty commit to this branch so it triggers a re-build in circleci? I'm not able to trigger this manually and I don't have permission to push commits to your fork.

You can do it this way:

git commit -m "Empty commit to force checks to run" --allow-empty
git push

susodapop avatar Apr 29 '22 15:04 susodapop

@susodapop I've rebased it to latest master and force pushed. That will ensure it's up to date with any other changes on master and trigger a rebuild without the need to pollute history with empty commits.

rjmunro avatar May 05 '22 00:05 rjmunro

@soulteary The latest version of maildev/maildev is 2.0.4 and was pushed 15 hours ago as I write this, by the djfarrelly account who created the original version. So I don't think there is anything to gain by switching to your fork.

https://hub.docker.com/r/maildev/maildev/tags

rjmunro avatar May 18 '22 12:05 rjmunro

@rjmunro In fact, my fork was merged into the original repo shortly after I left a comment one or two months ago. 😄

It really doesn't do any good to look at this two months later. Just ignore that message.

soulteary avatar May 18 '22 19:05 soulteary

Thanks for pointing this out @rjmunro. The maildev image was updated in commit 65d0eb

eradman avatar Jul 25 '23 16:07 eradman