git-pw icon indicating copy to clipboard operation
git-pw copied to clipboard

State should be case sensitive and follow the exact spelling

Open andy-shev opened this issue 7 years ago • 1 comments
trafficstars

When run git pw patch update --state <STATE> I have to provide an exact spelling of the <STATE> in question. However, when I got information about current state (either via git pw path list or looking at the result page from git pw patch update --state <STATE>) I see it spelled wrong.

First attempt:

% git pw patch update 993589 --state superseeded # **UPDATE** typo is here!

{u'state': [u'Invalid state superseeded. Expected one of: New, Under Review, Accepted, Rejected, RFC, Not Applicable, Changes Requested, Awaiting Upstream, Superseded, Deferred, Needs Review / ACK.']}

Second attempt:

% git pw patch update 993589 --state Superseded
| State      | superseded                                                              |

P.S. Under Review is spelled as under-review inside the tool which is wrong. pwclient doesn't have such issue.

andy-shev avatar Nov 14 '18 12:11 andy-shev

Ah, I made a typo, so, it works, but makes the view inconsistent. So, consider this as an enhancement.

andy-shev avatar Nov 14 '18 13:11 andy-shev