SocketIOClient-Unreal icon indicating copy to clipboard operation
SocketIOClient-Unreal copied to clipboard

Plugin does not build with strict includes

Open knapsu opened this issue 1 year ago • 2 comments

Plugin fails to build when strict include checks are enabled. This can be easily tested with UAT command

.\RunUAT.bat BuildPlugin -Plugin="{workspacePath}\Engine\Plugins\SocketIOClient\SocketIOClient.uplugin" -StrictIncludes -Package="{workspacePath}\LocalBuilds"

What -StrictIncludes does is adding -DisableUnity -NoPCH -NoSharedPCH to UBT when compiling. This ensures that each code file has all the needed includes and therefore is of a good quality on that side.

Will create a pull request that fixes some of the issues.

knapsu avatar May 17 '24 11:05 knapsu

Pull request created. This is a partial fix because there is still a thing with sio_socket.h that I was unable to solve.

knapsu avatar May 17 '24 11:05 knapsu

Good idea, thanks for getting the PR done; merged the includes update.

getnamo avatar May 20 '24 16:05 getnamo