lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

Fix Lightning Address email regex to support unicode domains

Open bumi opened this issue 4 years ago • 2 comments

Our email regex that we use to check if something is a lightning address does not support unicode domains like (丰.ml) Can we safely change that: https://github.com/getAlby/lightning-browser-extension/blob/57db3b3a178acc4ad0109c543c970f33787cd410/src/common/lib/lnurl.ts#L13 ?

email regex is hard. maybe we just use: /\S+@\S+/ ?

bumi avatar Nov 10 '21 11:11 bumi

Sir can I work on this issue ?

SiddheshKukade avatar Mar 18 '23 11:03 SiddheshKukade

Hey is this issue still valid @pavanjoshi914. If so, can you please assign this to me.

ankitzm avatar Oct 06 '23 17:10 ankitzm