lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

Published 20 hours ago • verified publisher icon getAlby

[Feature] Copy content of QR codes when clicking

Open reneaaron opened this issue 2 years ago • 5 comments

Feature description

https://primal.net/e/note1fe3ys26tdg5ffuvkpty4lkpnxjndjq92stk6lffc8jyc6yrxjg0qq2qst8

Describe the solution

The whole QR-Code element should be clickable (maybe add an overlay on hover that says "click to copy").

Describe alternatives

No response

Additional context

No response

Are you working on this?

None

reneaaron avatar Nov 07 '23 19:11 reneaaron

@reneaaron I can work on this issue if some design is made for it.

volfiros avatar Nov 07 '23 21:11 volfiros

@Rithvik-padma Sounds great, thanks for your help! 🙌

@stackingsaunter Can you maybe help with that? I was thinking of a very lightweight overlay saying "click to copy" (or maybe just the copy icon with some hover state?)

reneaaron avatar Nov 07 '23 23:11 reneaaron

So I think we should make the whole card clickable, but then I would go back to a button shadow (shadow-sm as far as I remember), to maintain the pattern that buttons have shadows. @reneaaron what do you think?

Hover color is gray 50 in light mode and surface 01 in dark

image

We can also delete the copy button which becomes redundant with a whole card clickable

image

stackingsaunter avatar Nov 08 '23 14:11 stackingsaunter