lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

fix: dual currency input styles

Open abhiShandy opened this issue 2 years ago • 9 comments

Describe the changes you have made in this PR

Change a few Tailwind CSS classes to fix placeholder, text and border colors in the dual currency input box

Link this PR to an issue [optional]

This addresses a part of task 5 mentioned in #2511

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

BEFORE <> AFTER

Screenshot 2023-10-04 at 7 33 05 AM Screenshot 2023-09-30 at 10 43 46 AM Screenshot 2023-10-04 at 7 33 22 AM Screenshot 2023-09-30 at 10 43 38 AM Screenshot 2023-10-04 at 7 33 49 AM Screenshot 2023-09-30 at 10 40 28 AM Screenshot 2023-10-04 at 7 33 57 AM Screenshot 2023-09-30 at 10 40 39 AM

How has this been tested?

This has been tested visually after running yarn run dev:chrome

Checklist

  • [ ] Self-review of changed code
  • [ ] Manual testing
  • [ ] Added automated tests where applicable
  • [ ] Update Docs & Guides
  • For UI-related changes
  • [x] Dark mode
  • [ ] Responsive layout

abhiShandy avatar Sep 30 '23 14:09 abhiShandy

@stackingsaunter this PR makes easy changes to fix the border, text and placeholder colors in both currency input and description input below it.

abhiShandy avatar Sep 30 '23 14:09 abhiShandy

@abhiShandy Thanks for the PR, however the colors don't seem to match the designs?

https://user-images.githubusercontent.com/68239231/248509813-13fbcea9-62c3-4cbf-ae9b-aafcdc0f704b.png

Where did you get those colors from? :thinking:

reneaaron avatar Oct 03 '23 12:10 reneaaron

@abhiShandy Thanks for the PR, however the colors don't seem to match the designs?

https://user-images.githubusercontent.com/68239231/248509813-13fbcea9-62c3-4cbf-ae9b-aafcdc0f704b.png

Where did you get those colors from? 🤔

I used this https://github.com/getAlby/lightning-browser-extension/issues/2511#issuecomment-1741777180

abhiShandy avatar Oct 03 '23 12:10 abhiShandy

it's always better to add before vs. after screenshots for such small UI changes. there are other tasks as well linked in the issue right? please specify which task among those is completed here

pavanjoshi914 avatar Oct 04 '23 08:10 pavanjoshi914

why neutral for dark mode? same can be achieved even by tweaking gray one isnt it?

pavanjoshi914 avatar Oct 04 '23 08:10 pavanjoshi914

it's always better to add before vs. after screenshots for such small UI changes. there are other tasks as well linked in the issue right? please specify which task among those is completed here

I have added the screenshots for comparison in the first comment, and have mentioned the specific task

why neutral for dark mode? same can be achieved even by tweaking gray one isnt it?

Neutral and gray are different colors

Screenshot 2023-10-04 at 7 38 48 AM Screenshot 2023-10-04 at 7 38 53 AM

abhiShandy avatar Oct 04 '23 11:10 abhiShandy

Can we merge this?

abhiShandy avatar Feb 23 '24 16:02 abhiShandy

@pavanjoshi914 good to go I think?

stackingsaunter avatar Feb 25 '24 13:02 stackingsaunter

@stackingsaunter are design's correct? @reneaaron had some design related suggestions here i think.

pavanjoshi914 avatar Feb 26 '24 07:02 pavanjoshi914

closing due to lack of activity

abhiShandy avatar Apr 08 '24 14:04 abhiShandy