lightning-browser-extension
lightning-browser-extension copied to clipboard
fix: dual currency input styles
Describe the changes you have made in this PR
Change a few Tailwind CSS classes to fix placeholder, text and border colors in the dual currency input box
Link this PR to an issue [optional]
This addresses a part of task 5 mentioned in #2511
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)
Screenshots of the changes [optional]
BEFORE <> AFTER
How has this been tested?
This has been tested visually after running yarn run dev:chrome
Checklist
- [ ] Self-review of changed code
- [ ] Manual testing
- [ ] Added automated tests where applicable
- [ ] Update Docs & Guides
- For UI-related changes
- [x] Dark mode
- [ ] Responsive layout
@stackingsaunter this PR makes easy changes to fix the border, text and placeholder colors in both currency input and description input below it.
@abhiShandy Thanks for the PR, however the colors don't seem to match the designs?
https://user-images.githubusercontent.com/68239231/248509813-13fbcea9-62c3-4cbf-ae9b-aafcdc0f704b.png
Where did you get those colors from? :thinking:
@abhiShandy Thanks for the PR, however the colors don't seem to match the designs?
https://user-images.githubusercontent.com/68239231/248509813-13fbcea9-62c3-4cbf-ae9b-aafcdc0f704b.png
Where did you get those colors from? 🤔
I used this https://github.com/getAlby/lightning-browser-extension/issues/2511#issuecomment-1741777180
it's always better to add before vs. after screenshots for such small UI changes. there are other tasks as well linked in the issue right? please specify which task among those is completed here
why neutral for dark mode? same can be achieved even by tweaking gray one isnt it?
it's always better to add before vs. after screenshots for such small UI changes. there are other tasks as well linked in the issue right? please specify which task among those is completed here
I have added the screenshots for comparison in the first comment, and have mentioned the specific task
why
neutralfor dark mode? same can be achieved even by tweaking gray one isnt it?
Neutral and gray are different colors
Can we merge this?
@pavanjoshi914 good to go I think?
@stackingsaunter are design's correct? @reneaaron had some design related suggestions here i think.
closing due to lack of activity