lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

Published 20 hours ago • verified publisher icon getAlby

refactor(lnurl): getDetails - avoid typecasting

Open escapedcat opened this issue 3 years ago • 3 comments
trafficstars

Mainly trying to avoid let lnurlDetails = {} as LNURLDetails; and be more explicit about types. So instead of forcing the type we let TS figure it out by defining possible types in other places.

escapedcat avatar Sep 29 '22 08:09 escapedcat

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

Want to sponsor the next build? send some sats to ⚡️[email protected] (don't forget to provide your name)

Don't forget: keep earning sats!

github-actions[bot] avatar Sep 29 '22 08:09 github-actions[bot]

Also I could not find the place where the action string from LNURL Auth is used. Can you point me to that again? 🙇

Uhm, I'm also not sure tbh. @reneaaron do you know of a real-world usecase?

escapedcat avatar Oct 10 '22 09:10 escapedcat

Currently geyser.fund.

reneaaron avatar Oct 10 '22 10:10 reneaaron