lightning-browser-extension icon indicating copy to clipboard operation
lightning-browser-extension copied to clipboard

Chore/deps swc 220 plus workaround

Open escapedcat opened this issue 3 years ago • 4 comments

Latest swc updates break our Jest setup. There's is a workaround but we still need to adjust our setup.
Staying on v205 is currently working for us.

escapedcat avatar Jul 30 '22 07:07 escapedcat

Build files:

github-actions[bot] avatar Jul 30 '22 07:07 github-actions[bot]

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
@swc/[email protected] (upgraded) postinstall package.json
Pull request report summary
Issue Status
Install scripts ⚠️ 1 issue
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

socket-security[bot] avatar Jul 30 '22 07:07 socket-security[bot]

what is this one about?

bumi avatar Aug 15 '22 09:08 bumi

what is this one about?

Adjusted the description

escapedcat avatar Aug 15 '22 09:08 escapedcat

is this still active or can we close it?

bumi avatar Oct 16 '22 19:10 bumi

is this still active or can we close it?

We should solve this

escapedcat avatar Oct 17 '22 06:10 escapedcat

so then let's solve this. July is already very old.

bumi avatar Oct 26 '22 14:10 bumi

It's about priorities. Happy to touch this after the manifest.

escapedcat avatar Oct 26 '22 14:10 escapedcat

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

github-actions[bot] avatar Nov 18 '22 13:11 github-actions[bot]

Thanks, I added the link to the swr discussion to the description for later documentation.

I think, your current fix with removing spyOn is ok for now.

Thanks, already watching that discussion.

escapedcat avatar Nov 28 '22 15:11 escapedcat