lightning-browser-extension
lightning-browser-extension copied to clipboard
getAlby
LNURL-auth with BlueWallet
Describe the bug
Using LNURL-auth currently leads to different identities when you import your Alby account into BlueWallet.
To Reproduce
- Go to lightninglogin.live (or any other site with LNURL-auth support)
- Login with your Alby extension and remember the generated identity
- Logout
- Import your Alby account into BlueWallet
- Try to login again by scanning the QR-Code with BlueWallet
- The identities do not match
Expected behavior
The identities generated from step 2 and step 5 should be the same.
Are you working on this issue?
No.
this is known and fixed in https://github.com/getAlby/lightning-browser-extension/pull/968
We had updated the key generation to follow the scheme with bluewallet (because with custodial wallets the key is derived from the login/password). But we still did use an invalid hash.
the problem with this is: how to best roll it out. because it would break the login for existing users.
Ahh, okay. Isn't that somehow the same as with the legacy signing option we already have in Alby? Can we maybe even change the signing key based on this setting, too?
The sooner we switch the less people are impacted by this change, right?
that legacy singing was when we changed the way we generate keys to be compatible with bluewallet. It is related, but not the same.
Yes, the sooner the better.
I see. How about adding another setting and putting them in some separate section of the settings page that is a little less prominent than the current one and remove them in some months?
That way we would offer a migration path for existing users but don't overwhelm new users with those settings.