dbt-snowflake-monitoring icon indicating copy to clipboard operation
dbt-snowflake-monitoring copied to clipboard

Column Name mismatch in query_direct_table_access docs

Open kirk-dave opened this issue 2 years ago • 4 comments

In the query_direct_table_access model there is a mismatch between the docs and the model for table_name.

Happy to contribute a fix for this.


https://github.com/get-select/dbt-snowflake-monitoring/blob/6c440e1c2b7e3f32219e14c9cb7b0cabae5bcebe/models/query_direct_table_access.yml#L15-L16

https://github.com/get-select/dbt-snowflake-monitoring/blob/6c440e1c2b7e3f32219e14c9cb7b0cabae5bcebe/models/query_direct_table_access.sql#L6

kirk-dave avatar Jun 09 '23 18:06 kirk-dave

If a fix is wanted, let me know what's preferred: table_name or full_table_name

kirk-dave avatar Jun 09 '23 18:06 kirk-dave

Thanks @kirkbrunson-dave! A PR would be amazing. Let's update the docs to align with what is already in the model.

Thanks again for flagging.

ian-whitestone avatar Jun 09 '23 19:06 ian-whitestone

Great! @ian-whitestone Do I need to do anything to get set up as a contributor? Getting the following pushing the PR to a feature branch Screen Shot 2023-06-09 at 4 40 44 PM

kirk-dave avatar Jun 09 '23 20:06 kirk-dave

@kirkbrunson-dave it looks like an issue with your git command

Once you have pushed your commit to your forked repo, you should be able to open a PR from the github UI https://jarv.is/notes/how-to-pull-request-fork-github/

ian-whitestone avatar Jun 09 '23 22:06 ian-whitestone