react-pricing-table icon indicating copy to clipboard operation
react-pricing-table copied to clipboard

feat(PricingSlot): custom accessors

Open Coriou opened this issue 6 years ago • 5 comments

PricingSlot has two new props: titleAccessor & priceAccessor, allowing to pass custom price & title components respectively

Not ready to be merged, but is working. Check the example:

$ npm start
# localhost:8080

To do:

  • [x] Write / update tests
  • [x] Document readme
  • [x] Provide an example

Coriou avatar May 15 '19 22:05 Coriou

Spamming with PRs here. For a quick check of everything in #11, #10 & #9, you can have a look at coriou/react-pricing-table#develop

Coriou avatar May 15 '19 22:05 Coriou

@Coriou thanks a ton for this pr and all the updates.

I will get to reviewing them today.

gergely-nagy avatar May 16 '19 06:05 gergely-nagy

Hey, have you had some time to take a look yet ? Thanks

Coriou avatar May 20 '19 06:05 Coriou

That was fast :)

I'll make myself available in Gitter if you need to discuss this or help with merging all the PRs

Coriou avatar May 20 '19 07:05 Coriou

Thanks for your work! Trying to merge this PR ASAP 😄

gergely-nagy avatar May 20 '19 08:05 gergely-nagy