MapStore2
MapStore2 copied to clipboard
#10158 painless accessibility improvements
Description
Tiny changes that improve accessibility. Should hopefully not take longer than a minute to review.
What kind of change does this PR introduce?
- [x] Bugfix
Issue
What is the current behavior?
#10158
Bad Lighthouse Accessibility Score
What is the new behavior?
Better Lighthouse Accessibility Score through:
- Setting Document language
- Fixing a heading that should be a div
- providing a logo with an alt tag
- linking scale label with its form element
- enabling browser zoom
Breaking change
Does this PR introduce a breaking change?
- [x] No
Other useful information
Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible for people who need larger controls than disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming into the map using browser zoom should be able to notice the actual controls and recover from their mistake.
@fkellner thank you so much for your contribution. We will review as soon as possible. @allyoucanmap, let's evaluate a possible inclusion in 2024.01.01 (waiting for the review).
@fkellner is this PR ready for a new review then? Thank you so much.
Yes, I did the requested changes and it is ready from my side
@ElenaGallo please test on dev and let me know if we can backport on 2024.02.xx, thanks
Test passed, @allyoucanmap please backport on 2024.02.xx. Thanks