MapStore2 icon indicating copy to clipboard operation
MapStore2 copied to clipboard

#10158 painless accessibility improvements

Open fkellner opened this issue 1 year ago • 1 comments
trafficstars

Description

Tiny changes that improve accessibility. Should hopefully not take longer than a minute to review.

What kind of change does this PR introduce?

  • [x] Bugfix

Issue

What is the current behavior?

#10158

Bad Lighthouse Accessibility Score

What is the new behavior?

Better Lighthouse Accessibility Score through:

  • Setting Document language
  • Fixing a heading that should be a div
  • providing a logo with an alt tag
  • linking scale label with its form element
  • enabling browser zoom

Breaking change

Does this PR introduce a breaking change?

  • [x] No

Other useful information

Too much Zoom does seem to break the layout, but handing that responsibility to the end user is more accessible for people who need larger controls than disabling it. Map zoom is unaffected, and since using browser zoom enlarges map controls, users who tried zooming into the map using browser zoom should be able to notice the actual controls and recover from their mistake.

fkellner avatar Apr 04 '24 09:04 fkellner

@fkellner thank you so much for your contribution. We will review as soon as possible. @allyoucanmap, let's evaluate a possible inclusion in 2024.01.01 (waiting for the review).

tdipisa avatar Apr 04 '24 09:04 tdipisa

@fkellner is this PR ready for a new review then? Thank you so much.

tdipisa avatar Sep 11 '24 07:09 tdipisa

Yes, I did the requested changes and it is ready from my side

fkellner avatar Sep 12 '24 18:09 fkellner

@ElenaGallo please test on dev and let me know if we can backport on 2024.02.xx, thanks

allyoucanmap avatar Sep 13 '24 14:09 allyoucanmap

Test passed, @allyoucanmap please backport on 2024.02.xx. Thanks

ElenaGallo avatar Sep 16 '24 09:09 ElenaGallo