docker icon indicating copy to clipboard operation
docker copied to clipboard

feat: add renovate bot

Open buehner opened this issue 1 year ago • 3 comments
trafficstars

This introduces a renovate bot configuration and enables a scheduled github action that checks for dependency updates on all levels (github actions, docker base images). Renovate will then create pull requests whenever it detects new versions. Especially, this leads to the use of explicit docker image digests in the Dockerfile. This is an essential preparation for the suggestions made in GEOS-11231.

We tested this in a forked repo. Here is an example output: https://github.com/buehner/docker-geoserver-official/pull/5

Note: This does not produce auto-merges, but instead provides a helpful overview on base images that can be updated.

However: To get this running, a github secret named RENOVATE_TOKEN is required. The content of this secret is a personal github access token (classic) with the following scopes: repo (all) and workflow. As we do not have sufficient rights to create such a secret/token, it would be great if one of you could prepare this and let us know here @jodygarnett @aaime

Regarding GEOS-11231 we could then think about triggering a jenkins job to recreate the geoserver docker images based on the updated base images. The docker tags would not change, but by using explicit digests it would still be possible to use older images.

Pseudo example:

curl https://build.geoserver.org/job/JOB_NAME/buildWithParameters \
--user USER:TOKEN \
--data id=123 --data verbosity=high

buehner avatar Feb 09 '24 13:02 buehner

this won't catch updating tomcat as it is specified as a build argument

mprins avatar Feb 20 '24 10:02 mprins

@mprins looking at this change it could be possible https://github.com/renovatebot/renovate/pull/15751 ?

I just had a very quick look, but I will give it a try locally/in my repo as soon as I find some time.

buehner avatar Feb 20 '24 10:02 buehner

Ahh, got it now. We currently do not use the tomcat version in a FROM statement. But this would be "solved" by https://github.com/geoserver/docker/pull/45 i guess...

buehner avatar Feb 20 '24 11:02 buehner

Closed in favor of https://github.com/geoserver/docker/pull/64

buehner avatar Jul 30 '24 10:07 buehner