Replace ToGeo with Into or TryInto?

[jdroenner]

rust-geo still has the ToGeo trait in traits.rs. Is this trait still required? I guess the conversion traits are the way to go.

[frewsxcv]

Good idea. I don't think we have much of a reason to keep it around

[urschrei]

We can't use TryInto because it's recently been un-stabilised again, but do we actually need fallibility, or is Into enough?

[frewsxcv]

FYI, TryInto is stabilized again! It's hit the latest beta, but not yet stable

[urschrei]

Finally! 👯‍♂️

[frewsxcv]

https://github.com/search?l=Rust&q=togeo&type=Code

[frewsxcv]

Considering there's usage of this trait in the ecosystem, I'm going to mark it as deprecated:

https://github.com/georust/geo/pull/375

We can remove it in the future after some time has passed

Also the trait is not in geo-types, so it's not a breaking change for geo-types. I'll remove that label

[michaelkirk]

Just preparing to close the loop on this:

Looks like, though deprecating ToGeo was merged back in July 2019, it wasn't released until geo-0.13.0 in March 2020.

$ git tag --contains 97630b38 geo-0.13.0

So, what's a reasonable timeframe for removing it... some time after March 2021?

[urschrei]

I think 12 months is reasonable.

[frewsxcv]

Removed in https://github.com/georust/geo/pull/892