openlayers-editor
openlayers-editor copied to clipboard
fix: fix topology errors in line hit detection & optimizations
This fixes an issue where jsts may throw TopologyError errors when building the intersections due to the snappable lines built having invalid geometry. We also do some minor performance work by
- Parsing the lines to jsts representations a single time, instead of each call through the loop
- moving the
isSameLinecheck prior to theIntersectionOpfor some minor performance in the case we can avoid the work.
Others
- [x] It's not a hack or at least an unauthorized hack :).
- [x] Everything in ticket description has been fixed.
- [x] The author of the MR has made its own review before assigning the reviewer (made this a month ago and has been thoroughly tested).
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| openlayers-editor | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 21, 2024 4:51pm |
@megawac thx for the PRs and sorry for the late answer. I review all of them and try to be responsive in the next month.
@megawac can you fix the conflict? I will merge this even without test because it's usefull.
Done, the linting error appears to be an issue with a ci token