openlayers-editor icon indicating copy to clipboard operation
openlayers-editor copied to clipboard

fix: fix topology errors in line hit detection & optimizations

Open megawac opened this issue 2 years ago • 2 comments

This fixes an issue where jsts may throw TopologyError errors when building the intersections due to the snappable lines built having invalid geometry. We also do some minor performance work by

  1. Parsing the lines to jsts representations a single time, instead of each call through the loop
  2. moving the isSameLine check prior to the IntersectionOp for some minor performance in the case we can avoid the work.

Others

  • [x] It's not a hack or at least an unauthorized hack :).
  • [x] Everything in ticket description has been fixed.
  • [x] The author of the MR has made its own review before assigning the reviewer (made this a month ago and has been thoroughly tested).

megawac avatar Aug 09 '23 15:08 megawac

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openlayers-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 4:51pm

vercel[bot] avatar Aug 09 '23 15:08 vercel[bot]

@megawac thx for the PRs and sorry for the late answer. I review all of them and try to be responsive in the next month.

oterral avatar May 10 '24 11:05 oterral

@megawac can you fix the conflict? I will merge this even without test because it's usefull.

oterral avatar Jun 20 '24 06:06 oterral

Done, the linting error appears to be an issue with a ci token

megawac avatar Jun 21 '24 16:06 megawac