svelte-adapter-azure-swa icon indicating copy to clipboard operation
svelte-adapter-azure-swa copied to clipboard

Published 20 hours ago • verified publisher icon geoffrich

allow overriding default allowedRoles

Open tobiaskohlbau opened this issue 3 years ago • 4 comments

If an app needs login a requirement the current adapter could not support such scenarios. This PR address this by allowing the user to override the rules. By default nothing changes and everything is allowed by using the anonymous role.

tobiaskohlbau avatar Aug 23 '22 16:08 tobiaskohlbau

This PR may be superseded by #66, which will allow for greater customization of the config.

geoffrich avatar Sep 26 '22 14:09 geoffrich

Sorry for the late response, I've had a look into #66. Is the plan to superseed this or would you rather merge this now and have the details of #66 change it later on? If we would like to get this merged now I'm happy to address the requested changes.

tobiaskohlbau avatar Nov 21 '22 13:11 tobiaskohlbau

Hey - yeah, I think #66 will be the more robust solution, since it will allow applying allowedRoles to individual routes, and it would be weird to have a separate config option for a global allowedRoles. It fell off my radar a few months ago, and I'm hoping to get back to it soon (definitely before v1 of this adapter is released).

I'll leave this PR open until #66 is merged in case I change my mind, but let's hold off on making any more changes for now. Thanks!

geoffrich avatar Nov 30 '22 00:11 geoffrich

Thaks for the response, looking forward to the changes of #66. Let me know if I can help with anything to get that PR merged.

tobiaskohlbau avatar Nov 30 '22 08:11 tobiaskohlbau