Geoff Rich

Results 120 comments of Geoff Rich

It doesn't have all the details, but I took some notes on my solution for this: https://geoffrich.net/posts/marvel-filter-state/#heading-automatically-submitting-the-form-with-requestsubmit. It's for a Marvel comics search form that has both text inputs (that...

I agree that it makes sense to remove this check for `` elements: - The [corresponding axe-core rule](https://github.com/dequelabs/axe-core/pull/1071) has been deprecated - The [corresponding Lighthouse audit](https://web.dev/audio-caption/) has been deprecated -...

Also note that the [Svelte tutorial](https://svelte.dev/tutorial/sharing-code) currently has a compiler warning for missing audio captions. Either the rule should not check audio elements or the tutorial should be updated to...

I opened a PR to remove the warning for audio elements since it's causing the most issues and browsers don't support it. I made sure to note in the PR...

Hello! Can you provide a self-contained repo reproducing the issue? It's worth noting that the SWA CLI isn't fully supported with this adapter - that's what #96 is tracking.

There's also a case where the property isn't defined yet if the custom element definition is being lazy-loaded -- so I agree with Rich that being explicit makes sense. Old...

Why do you need this? Ideally you would use a [Vite plugin](https://kit.svelte.dev/docs/integrations#vite-plugins) instead, since that would apply during dev and build.

I swear this worked at one point, but not sure what might have broken it. Historically, using the SWA CLI with this adapter has been a little clunky since using...

@derkoe no rush, but please re-request my review on the PR once you've addressed my comments - that way it doesn't get lost in my inbox

@ktarmyshov I'm seeing a similar issue on the demo site after merging this PR, though I didn't see it while testing out the PR branch against another repo. I've opened...