BazingaGeocoderBundle icon indicating copy to clipboard operation
BazingaGeocoderBundle copied to clipboard

Drop support for Symfony < 5.4, add Symfony 6.4 and PHP 8.3 to CI

Open ker0x opened this issue 2 years ago • 6 comments
trafficstars

This PR drop support for Symfony < 5.4 and add 6.3 to the CI test matrix. It also update the .gitattributes that was outdated.

ker0x avatar Sep 25 '23 08:09 ker0x

Thanks. Before merging this we should wait for https://github.com/geocoder-php/Geocoder/pull/1184

norkunas avatar Oct 02 '23 06:10 norkunas

Friendly ping @norkunas! I have rebased my PR and include Symfony 6.4 and PHP 8.3 to the CI matrix !

ker0x avatar Dec 16 '23 17:12 ker0x

Sorry,will be available on wednesday,and will review 🙌

norkunas avatar Dec 16 '23 19:12 norkunas

@norkunas tests are green on my side (https://github.com/ker0x/geocoder-php-geocoder-bundle/actions/runs/7695337920). I will prefer to see this PR merge instead of #350 as there are too many problems with deprecations and Symfony 4.4

ker0x avatar Jan 29 '24 11:01 ker0x

I prefer to make a last release with fixed tests and then dropping support for 4.4

norkunas avatar Jan 29 '24 11:01 norkunas

@ker0x as `geocoder-php/Geocoder release is stalled, I think we can finish/merge this and release which will save us some trouble, because it's too hard to maintain such a broad version range so I had to completely disable 2 CI jobs

norkunas avatar May 23 '24 10:05 norkunas

@norkunas I have just updated the PR! I've removed the tests for Symfony 7.1 because I think that just testing on 7.2 is enough! WDYT?

ker0x avatar Jan 17 '25 10:01 ker0x

Btw can you update commit and pr title to reflect updates?

norkunas avatar Jan 17 '25 11:01 norkunas

@norkunas Done 👍

ker0x avatar Jan 17 '25 11:01 ker0x

Thank you @ker0x :) I was waiting for you to come back to this PR :wink:

norkunas avatar Jan 17 '25 11:01 norkunas