zhou zhuohan

Results 19 comments of zhou zhuohan

I think the unit test case ran fail is because `TestGetMessagesByID` function in `pulsaradmin/pkg/admin/subscription_test.go` use message `id.String()` as a map key to check if current messages are in a same...

> Shared subscription won't be introduced to Connector anymore. We will only use the Exclusive subscription because the Flink can handle the fallover logic internally. So the comments can be...

> Currently, Pulsar clients only support the client_credentials authentication type. The authentication type determines how to obtain an access token through an OAuth 2.0 authorization service. https://pulsar.apache.org/docs/3.3.x/security-oauth2/#configure-oauth2-authentication-in-pulsar-clients Since the latest...

Pulsar broker and bookie is written in Java. And I think it will be a little complicated if we mock broker code in the unit test.

It might be a big changes. Is it possible to remain `ConcurrentOpenHashMap` interface, and use `ConcurrentHashMap` as `ConcurrentOpenHashMap` interface realization? So that we may only need to modify `ConcurrentOpenHashMap` file.

> It will produce much more garbage code in Pulsar. > > The idea to reduce code changes seems good, but the `ConcurrentOpenHashMap` is not fully compatible with `ConcurrentHashMap`. Let...

I think there is no direct compression ratio ralated prometheus metrics in go sdk. Maybe we need to use these different compression algorithms to send same messages to different topics,...

I think this ci failed is because the PR added `brokerDeduplicationEnabled=true` global configuration. Which will affect all declared test cases. And I think if we need to test deduplication feature,...

Since merged in [953](https://github.com/apache/pulsar-client-go/pull/953), can we close this issue as completed? @RobertIndie