drupal-vm
drupal-vm copied to clipboard
geerlingguy
Remove Drush make support
Issue Type
- Bug Report
Summary
Drush make file site generation support has been removed as of Drush 9.0.0, see Remove make from Drush9.
Therefore we should, at some point, completely drop support for Drush make from Drupal VM (especially considering #1672 will start defaulting to Drush 9.0.0 with launcher...). It could still be managed to be used by individuals sticking with Drush 8.x, but they would be on their own making sure it was all working correctly.
For the short-term, I'm reworking the Drush make test to explicitly install Drush 8.1.15 from source so tests still pass. But for this ticket:
- [ ] Remove drush make bits from the nginx + drush make automated test.
- [ ] Remove drush make mentions in documentation.
- [ ] Remove the
example.drupal.make.ymlfile. - [ ] Open an upstream issue in the
geerlingguy.drupalrole to remove Drush makefile build support as well (after it's gone from Drupal VM... hopefully).
Related
- https://github.com/geerlingguy/drupal-vm/issues/1672
- https://github.com/geerlingguy/drupal-vm/issues/1595
Would like feedback from any Drupal VM users who are still using Drush make files—is this a critical feature for you?
I'm using DrupalVM to support a legacy Drupal 7 project. If Drush make support is removed, how would setting up Drupal 7 VMs work?
@SeanHeavey, where I work we deal exclusively with D7 and we've not used drush make ever since the deprecation was announced.
The idea would be to convert your make files into a composer.json file, but it's not that straight forward. Rest assured they are far more manageable after you make the change.
I would support this change, but it's worth noting that some hosts are still recommending make files for D7 sites. (I also maintain a legacy site.)
For instance, Platform.sh uses make files for both its "profile" and "project" options, and provides a make file in its example D7 site. Acquia Cloud provides options for make files in local development, though it's not prominently suggested anywhere. I didn't see anything in Pantheon regarding make files.
This is perhaps a side issue, but just noting that people who are using DrupalVM to set up local development on these hosts might be frustrated. There are probably workarounds (and it might be worth encouraging Platform, at least, to stop suggesting a make file by default).
@rootwork and @SeanHeavey - Thanks for the feedback. I was considering dropping Drush make support in Drupal VM 6, but I guess I'll let it go at least another version or two for now.
It will always be something that is possible, but at some point I will have to drop the configurations and official docs for it, as it's something I haven't used in a few years now and I'd rather not support it if I can't guarantee it works. Luckily the test that's running for it hasn't been unstable, so as long as that's the case I'll keep it in.